Skip to content

Fix CSV export for empty result sets #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GHX5T-SOL wants to merge 1 commit into from
Closed

Fix CSV export for empty result sets #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion assayer/exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@

from assayer.models import ModelResult

_FIELDNAMES = [
"model",
"output",
"tokens_input",
"tokens_output",
"latency_seconds",
"cost_usd",
"error",
]


def _to_dict(result: ModelResult) -> dict:
return {
Expand All @@ -23,7 +33,7 @@ def export(results: list[ModelResult], path: str) -> None:

if dest.suffix.lower() == ".csv":
with dest.open("w", newline="", encoding="utf-8") as f:
writer = csv.DictWriter(f, fieldnames=list(records[0].keys()))
writer = csv.DictWriter(f, fieldnames=_FIELDNAMES)
writer.writeheader()
writer.writerows(records)
else:
Expand Down
22 changes: 21 additions & 1 deletion tests/test_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,15 @@
from assayer.exporter import export
from assayer.models import ModelResult

_EXPECTED_FIELDS = {"model", "output", "tokens_input", "tokens_output", "latency_seconds", "cost_usd", "error"}
_EXPECTED_FIELDS = {
"model",
"output",
"tokens_input",
"tokens_output",
"latency_seconds",
"cost_usd",
"error",
}


def _results() -> list[ModelResult]:
Expand Down Expand Up @@ -93,6 +101,18 @@ def test_export_csv_has_all_headers(tmp_path):
assert set(reader.fieldnames) == _EXPECTED_FIELDS


def test_export_csv_empty_results_writes_headers(tmp_path):
path = tmp_path / "results.csv"
export([], str(path))

with path.open(encoding="utf-8") as f:
reader = csv.DictReader(f)
rows = list(reader)

assert set(reader.fieldnames or []) == _EXPECTED_FIELDS
assert rows == []


def test_export_csv_case_insensitive_extension(tmp_path):
path = tmp_path / "results.CSV"
export(_results(), str(path))
Expand Down