AllowAbsoluteReportPath#588
Open
MichielVT-SLC wants to merge 2 commits into
Open
Conversation
allow to use an absolute path for the reports directory
Contributor
|
Hi @MichielVT-SLC , I have seen that you changed netstandard2.0 to netstandard2.1. |
Contributor
Author
|
Hi @AntyaDev, |
4ca4c86 to
fc702e8
Compare
cdedaac to
c6d5c6e
Compare
2efc8d7 to
377a3c9
Compare
5a9d254 to
1626e74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow using an absolute path for the reports directory.
This required an upgrade to .NetStandard 2.1 Framework because the 'IsPathFullyQualified' function is not available in 2.0.
The framework upgrade caused a small issue in Dependency.fs which was solved by adding the string type to name variable.