Sync upstream Silo-Server main (#1681) - #204
Merged
Merged
Conversation
…oads (Silo-Server#1681) * fix(downloads): keep every audio track and subtitle in prepared downloads Remux and transcode downloads kept only the first audio track and dropped all embedded subtitles. Prepared MP4s now carry every audio track and the plain-text subtitles as MP4 timed text; ASS/SSA and PGS tracks are offered as manifest sidecar files extracted from the source through the shared subtitle cache. A track recipe version and tracks_v1 queue states keep older workers and transcode nodes from producing the legacy layout. * fix(downloads): freeze prepared audio tracks and copy only MP4-safe codecs A ready multi-track download's manifest now describes the audio tracks recorded when the file became ready, not the source's current probe, so replacing and rescanning the source cannot advertise tracks the MP4 lacks. A viewer selection that no longer names the same-language track falls back to the file's default. Remuxes copy an audio track only when MP4 can store its codec; a negotiated passthrough codec such as TrueHD, DTS, or PCM is encoded to AAC instead of failing the mux. The track-recipe migration's column additions are now idempotent so a rerun after a partial Up succeeds. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(api): refresh contract fixture after rebase * chore(downloads): name prepared track codec and layout constants --------- Co-authored-by: Quick104 <31828688+Quick104@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 4 seconds. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (31)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream Silo-Server#1681 (prepared downloads keep every audio track and subtitle).
internal/downloads. Resolved as the union of both sides, with the Silo module path rewritten and goimports run. Theget_system_info_okfixture was regenerated.go vetandgo testpass forinternal/downloads; openapi and fixtures were regenerated. CI covers the rest.AI disclosure
Written with Claude Code, model
claude-opus-5-5.🤖 Generated with Claude Code