Skip to content

ci: report filtered-out test shards under their real names - #215

Merged
JonahMMay merged 1 commit into
mainfrom
ci/required-shard-stubs
Sep 30, 2026
Merged

JonahMMay merged 1 commit into
mainfrom
ci/required-shard-stubs

Conversation

@JonahMMay

@JonahMMay JonahMMay commented Sep 30, 2026 •

Copy link
Copy Markdown

Branch protection requires Go tests (http), Go tests (rest) and Web tests (1..4/4). When paths-filter skips a matrix job, GitHub reports it under the unexpanded name (Go tests (${{ matrix.shard }})), so a web-only PR (e.g. #214) never gets the Go shard checks and stays blocked, and vice versa.

Adds go-test-full-skipped / web-test-coverage-skipped stubs that run only when the real shards are filtered out and report the same expanded names.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • CI results now include consistent check statuses when changes do not affect Go or web tests. In those cases, the relevant test shards are reported as not needed; when changes do affect those areas, the regular tests continue to run.
  • User Impact
    • No user-facing product changes are included in this update.

A skipped matrix job reports as 'Go tests (${{ matrix.shard }})', so a
web-only PR never produced the required 'Go tests (http)'/'(rest)'
checks (and a Go-only PR would never produce 'Web tests (n/4)'), leaving
it blocked. Stub jobs run exactly when the real shards are filtered out
and report the expanded names.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8435e7c1-0cd4-4b3f-b223-641577895dbd

📥 Commits

Reviewing files that changed from the base of the PR and between 8ea7ef1 and d90660c.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow adds matrix stub jobs for Go and web tests. When the respective path filters report no changes, these jobs emit passing messages for each shard.

Changes

CI matrix checks

Layer / File(s) Summary
Add skipped test matrix jobs
.github/workflows/ci.yml
Adds Go and web matrix jobs that run when their respective path filters report no changes. Each shard emits a passing message.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: cursoragent, quick104

Merge Risk: ⚪ Minimal · up to d9066

The change adds passing stub jobs with the expanded check names when Go or web shards are filtered out, which unblocks required checks. No actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to d9066

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/ci.yml: Adds go-test-full-skipped, with http and rest matrix shards, which runs only when Go changes are absent and emits a passing message for each skipped shard.
  • observed — Modified behavior in .github/workflows/ci.yml: Adds web-test-coverage-skipped, with shards 1–4, which runs only when web changes are absent and emits a passing message for each skipped shard.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: reporting filtered-out Go and web test shards under their real matrix-expanded names.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JonahMMay
JonahMMay merged commit faa3206 into main Sep 30, 2026
21 checks passed
@JonahMMay
JonahMMay deleted the ci/required-shard-stubs branch September 30, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant