fix(playback): drop default_base_moof from progressive remux (Tizen native player) - #217
Merged
Merged
Conversation
Samsung Tizen's native player (capi-media-player, used by the Prairie
Tizen app) cannot follow moof-relative tfhd offsets. On a progressive
fMP4 remux written with default_base_moof it plays the first fragment,
then stalls with no audio ("Not supported audio codec but video can be
played"), so every Tizen remux failed and recovery fell through to an
HDR encode that has no recipe (Iron Man: HEVC DV8 + TrueHD 7.1).
The progressive remux is one byte stream, not MSE/CMAF segments, so
explicit base data offsets are correct for it and every progressive
demuxer (browser <video>, Media3, AVFoundation) reads them. Verified on a
QN700B (Tizen 6.5) with the server's exact recipe piped through ffmpeg:
fails with the flag, plays with it removed, with DV8 kept (hev1) and with
DV stripped (hvc1), AAC 5.1 and E-AC-3 alike.
Add an invariant so an upstream sync cannot restore the flag unnoticed.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progressive fMP4 remuxes don't play on Samsung Tizen's native player (capi-media-player, used by the Prairie Tizen app). The player can't follow moof-relative
tfhdoffsets (default_base_moof): it plays the first fragment, then stalls with no audio and reports "Not supported audio codec but video can be played". Every Tizen remux failed this way, and failure recovery then fell through to an HDR encode that has no recipe.Found with Iron Man (HEVC Dolby Vision Profile 8 + TrueHD 7.1 Atmos only), which has to be remuxed for its audio.
Change
-movflagschanges fromfrag_keyframe+delay_moov+default_base_mooftofrag_keyframe+delay_moov.delay_moovstays, for copied E-AC-3/Atmos.TestBuildRemuxArgsOmitsDefaultBaseMoof.prairie-invariants.txtentry, so an upstream sync can't restore the flag unnoticed.Why it's safe for other clients
The progressive remux is a single byte stream, not MSE/CMAF segments, so explicit base data offsets are correct for it. Browser
<video>(the web player consumesserver_remux_progressivethrough<video src>, not MSE), Media3's fragmented MP4 extractor, and AVFoundation all read explicit offsets. HLS segments are produced by ffmpeg's HLS muxer and are unaffected.Verification
On a QN700B (Tizen 6.5), clips of the Iron Man source, each 45 s from 0:00, piped through ffmpeg exactly as
buildRemuxArgsWithAudioV3builds them:hev1, AAC 5.1,default_base_moof)hvc1)default_base_moof, E-AC-3 instead of AACdefault_base_moof, 2 s fragmentsdefault_base_moofremoved (DV8hev1, AAC 5.1)default_base_moof, DV strippedempty_moov, withoutdefault_base_moofGo isn't installed on the machine this was made on, so the unit tests are left to CI. The invariant check passes on an LF-normalized checkout (24/24).
Related, not in this PR
The 2026-08-28 upstream sync (#174) also reverted #153 ("choose the remux container instead of always writing MP4").
HandleStreampasses a literal"mp4"again, andmovflagsare no longer MP4-only. Iron Man doesn't need that fix: its TrueHD must be re-encoded, and Matroska with AAC didn't play on the TV. It is still a regression worth restoring separately, with an invariant.🤖 Generated with Claude Code
Summary by CodeRabbit
default_base_moofflag.