Repository navigation
fix(connect): reject non-Prairie servers on manual URL entry - #119
Merged
Merged
Conversation
The manual "Add server" screen skipped checkServer and routed straight to login, so any address (e.g. a Jellyfin host) reached Quick Connect and password login, which then failed with a bare "Not found". - Probe manual URLs with checkServerCandidates before opening login, surfacing failures and needs-setup inline. - checkServer now reports "not a Prairie server" when both setup routes are missing, and rejects 200 responses without a boolean needs_setup field. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
You could enter a non-Prairie address such as
jellyfin.jonahmay.neton the Add server screen and still reach login. Both Quick Connect and password login then failed with a bare "Not found".ManualServerScreennever rancheckServer. It sent the typed URL straight to login. The saved-server and discovered-server paths already ran the check.Changes
ManualServerScreennow checks the URL withbuildManualUrlCandidates+checkServerCandidatesbefore opening login. A bare host is tried as https first, then http. While it checks, the button reads "Checking…". A failed check or a server that isn't set up yet shows an error under the field.checkServer:/api/v2/system/setupand/api/v1/auth/setupreturn 404 or 405.needs_setup. This catches web servers that answer every path.test/api/check_server_test.dart(v2 success, v1 fallback, both routes 404, 200 without a setup payload).Notes
needs_setupin its setup response.Testing
flutter testinprairie_core: all 193 tests pass.flutter analyzeis clean on the changed files.🤖 Generated with Claude Code