Repository navigation
fix(tv): remote media keys act directly; center the seek preview on the thumb - #124
Merged
Merged
Conversation
The preview bubble was placed as if it were always 176px wide (a trickplay tile) and against the full bar width, so a bare timecode sat ~50px behind the thumb and drifted further toward the ends. Lay it out from its real width, centered on the thumb's inset track position, clamped to the bar. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Pressing play/pause on the Samsung remote only counted as "any key": it brought the player chrome up without pausing, and the on-screen button then had to be focused and selected. Both players now handle the remote's media keys wherever focus is: play/pause toggles, play and pause set the state, stop leaves the player, and fast-forward/rewind skip 15s (VOD only). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
fix(tv): make the remote's play/pause and transport keys act directly
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings two fixes to
mainthat missed it.main.Remote media keys act directly (from #123)
In both the live TV and regular players, pressing play/pause on the Samsung remote brought up the controls but didn't pause. Both players now handle the remote's transport keys wherever focus is:
Seek preview centred on the thumb (8818ec9)
The time bubble was positioned as if it were always as wide as a trickplay thumbnail (176 px), measured against the full width of the bar. Without trickplay it is just a narrow time label, so it sat about 50 px behind the thumb and drifted further toward the ends. It now uses its real width, centred on the thumb's position along the inset track and clamped to the bar (
seekPreviewLeft).Testing
dart analyze lib test: no issuesflutter test(prairie_core): 202 passed, including new tests for both fixes.🤖 Generated with Claude Code