Skip to content

fix(tv): let volume, mute and Home pass through the players - #125

Merged
JonahMMay merged 1 commit into
mainfrom
fix/tv-remote-system-keys
Sep 30, 2026
Merged

JonahMMay merged 1 commit into
mainfrom
fix/tv-remote-system-keys

Conversation

@JonahMMay

Copy link
Copy Markdown
Contributor

Summary

  • With the player chrome hidden, any remote key other than Back and the transport keys brought the chrome up. That meant changing the volume opened the player UI, and Home needed two presses.
  • Adds isSystemRemoteKey (volume up/down, mute, Home) in remote_media_keys.dart. The VOD and Live TV players' idle-key handlers now return ignored for these keys, so the TV handles them.
  • The check covers goHome, browserHome and home, since which key code the Tizen engine sends for Home hasn't been confirmed.

Test plan

  • flutter test test/player/remote_media_keys_test.dart (not run locally)
  • On the TV: volume/mute during playback doesn't show the chrome
  • On the TV: one press of Home leaves the app

🤖 Generated with Claude Code

With the player chrome hidden, every remote key other than Back and the
transport keys counted as "any key": changing the volume brought the chrome
up, and Home's first press was swallowed so it took two. Both players now
ignore these keys and leave them to the TV.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@JonahMMay
JonahMMay merged commit d238cf3 into main Sep 30, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c275d20b-1acc-421e-b468-4a5effe2609f

📥 Commits

Reviewing files that changed from the base of the PR and between 1adeba0 and b85a9b1.

📒 Files selected for processing (4)
  • flutter/packages/prairie_core/lib/src/player/remote_media_keys.dart
  • flutter/packages/prairie_core/lib/src/screens/live_tv_player_screen.dart
  • flutter/packages/prairie_core/lib/src/screens/player_screen.dart
  • flutter/packages/prairie_core/test/player/remote_media_keys_test.dart
 _____________________________________________________________________________
< I took both the red pill and the blue pill. Now I'm stuck in a code review. >
 -----------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JonahMMay
JonahMMay deleted the fix/tv-remote-system-keys branch September 30, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant