Skip to content

Fix issues with version 0.6 of SE#41

Open
broffey wants to merge 2 commits into
PreLeyZero:masterfrom
broffey:master
Open

Fix issues with version 0.6 of SE#41
broffey wants to merge 2 commits into
PreLeyZero:masterfrom
broffey:master

Conversation

@broffey

@broffey broffey commented Jul 27, 2022

Copy link
Copy Markdown

No description provided.

broffey added 2 commits July 27, 2022 11:49
Moved tech around that were breaking tech tree. Replaced KI red/yellow cubes with Production Science/Materiel Science 3 respectively as the cubes aren't accepted by the SE labs
Fix issues with version 0.6 of SE

@PreLeyZero PreLeyZero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to insert the KI cubes into their matching SE/K2 labs, instead of switching them with normal science packs.
Using
table.insert(data.raw.lab[LAB-KEY].inputs, 'fi_ki_science')
table.insert(data.raw.lab[LAB-KEY].inputs, 'fu_ki_science')

@broffey

broffey commented Jul 27, 2022

Copy link
Copy Markdown
Author

I would suggest to insert the KI cubes into their matching SE/K2 labs, instead of switching them with normal science packs. Using table.insert(data.raw.lab[LAB-KEY].inputs, 'fi_ki_science') table.insert(data.raw.lab[LAB-KEY].inputs, 'fu_ki_science')

The issue with this is the post processing of SE overwrites the labs with a hardcoded progression path that overwrites any lab settings.

@PreLeyZero

Copy link
Copy Markdown
Owner

Thats classic SE. One option would be to turn the "fu_big_lab" into a module lab, so just make a cheap recipe for it and change its inputs to the 2 cubes.

@esphas

esphas commented Oct 7, 2022

Copy link
Copy Markdown

Hello, I'm playing se+k2+248k recently, and I think as of SE v0.6.87 the labs already accept KI cubes (not sure if that's the earliest version though), but the problem with KFK and rocket science pack is still there.
I've copied those lines about KFK to publish as a temporary fix (cause my dedicated server needs it) if you don't mind @broffey .


relative: I checked science-labs.lua in space-exploration-postprocess and saw code like:

if data.raw["lab"]["burner-lab"] then
  local burn_lab = data.raw["lab"]["burner-lab"]
  local prev_inputs = burn_lab.inputs
  local burn_lab_inputs = {
    "basic-tech-card",
    "automation-science-pack",
    "logistic-science-pack",
  }

  -- Ensure other packs that are available in this lab are still availabe
  for _, pack in pairs(prev_inputs) do
    if not data_util.table_contains(burn_lab_inputs, pack) then
      table.insert(burn_lab_inputs, pack)
    end
  end

  burn_lab.inputs = burn_lab_inputs
end

@Chaoschaot232

Copy link
Copy Markdown
Collaborator

I'll take a look into this, if this is still a thing and if so I'll think about a solution here so stay tuned on this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants