Hi! Thanks for this library. I tested 0.1.1 against a local stub server and found two related problems:
1. A missing answer value is read as 0.0. If the API returns {"is_fraud":{"type":"noul"}}, response.noul("is_fraud") returns 0.0 instead of failing (Jackson defaults missing primitives). In a payment check, that means a malformed response silently reads as "not fraud" and the transaction goes through. Enabling FAIL_ON_MISSING_CREATOR_PROPERTIES on the mapper catches the missing fields, but not an explicit null.
2. A missing or mistyped answer surfaces later, as IllegalArgumentException. systemOne() returns normally, and the error only appears when reading the answer, so catch (TypeSafeException e) doesn't catch it.
I can send a PR for both if you agree.
Also, would you be open to an async API (systemOneAsync returning a CompletableFuture)?
Hi! Thanks for this library. I tested
0.1.1against a local stub server and found two related problems:1. A missing answer value is read as
0.0. If the API returns{"is_fraud":{"type":"noul"}},response.noul("is_fraud")returns0.0instead of failing (Jackson defaults missing primitives). In a payment check, that means a malformed response silently reads as "not fraud" and the transaction goes through. EnablingFAIL_ON_MISSING_CREATOR_PROPERTIESon the mapper catches the missing fields, but not an explicitnull.2. A missing or mistyped answer surfaces later, as
IllegalArgumentException.systemOne()returns normally, and the error only appears when reading the answer, socatch (TypeSafeException e)doesn't catch it.I can send a PR for both if you agree.
Also, would you be open to an async API (
systemOneAsyncreturning aCompletableFuture)?