feature: ISSUE-282 — ping manufacturing role in forum thread when order is submitted#320
Merged
GitAddRemote merged 2 commits intomainfrom Apr 5, 2026
Merged
feature: ISSUE-282 — ping manufacturing role in forum thread when order is submitted#320GitAddRemote merged 2 commits intomainfrom
GitAddRemote merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a non-blocking follow-up message in newly created manufacturing order forum threads that mentions the configured manufacturing role, so staff are notified immediately when an order is submitted.
Changes:
- Widen the created thread type to
ThreadChannelsothread.send()is type-safe. - After thread creation, send a role mention message into the thread with
allowedMentions.rolesproperly scoped, and treat failures as non-fatal (warn + continue). - Add tests for ping-on-success, ping failure being non-blocking, and skip behavior when
manufacturingRoleIdis empty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/commands/order-submit.command.ts | Sends a role ping message into the created order thread with guarded config + non-fatal error handling. |
| src/commands/tests/order-submit.command.test.ts | Extends mocks and adds tests for ping success/failure/skip scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MANUFACTURING_ROLE_IDmanufacturingRoleIdis empty (defensive guard in addition to the existing config validation)thread.sendfailure is caught, logged atwarn, and the success reply is still sent to the user{ id: string }toThreadChannelso.send()is type-safeTest plan
thread.sendcalled with correctcontentandallowedMentionson successthread.sendfailure does not block the successeditReply— warn is loggedmanufacturingRoleIdis emptynpm run quality)Closes #282