Add page objects for virtual_combinations per-combination files#1047
Open
PrestaEdit wants to merge 3 commits into
Open
Add page objects for virtual_combinations per-combination files#1047PrestaEdit wants to merge 3 commits into
PrestaEdit wants to merge 3 commits into
Conversation
…files Companion to PrestaShop/PrestaShop#41825. Adds: - virtualCombinationsProductDescription on the BO Products page - setCombinationVirtualProductFile / getCombinationVirtualProductFileName on the combinations tab - getProductDownloadFileName on the FO product page Some selectors are marked TODO and need confirmation against the rendered DOM. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ot guessed The combination-modal field ids are generated deterministically by Symfony from the core form structure (combination_form root + embedded VirtualProductFileType); only the FO download selector remains to confirm against the rendered theme. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Companion to PrestaShop/PrestaShop#41825 (design pivot, discussion #41826): remove the dropped virtual_combinations product-type description, add setCombinationIsVirtual for the per-combination virtual switch; the per-combination file methods are unchanged (file decoupled from the flag). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to PrestaShop/PrestaShop#41825 (new
virtual_combinationsproduct type, with one downloadable file per combination).Adds the page-object methods used by the new core UI campaign
23_virtualCombinations:boProductsPage.virtualCombinationsProductDescriptiontabCombinations.setCombinationVirtualProductFile()/getCombinationVirtualProductFileName()product.getProductDownloadFileName()FakerProduct.typeis already typed asstring, so no faker change was needed.Note: some selectors are marked
// TODO(selector)— the combination-modal virtual-file ids are inferred from the coreCombinationFormType(which embedsVirtualProductFileTypeas childvirtual_product_file,#combination_form_*prefix) and the FO download selector needs confirmation against the rendered theme DOM.tsc --noEmitand ESLint pass.🤖 Generated with Claude Code