-
Notifications
You must be signed in to change notification settings - Fork 0
Update GitHub Actions and upgrade to Python 3.13 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,25 +17,59 @@ jobs: | |||||
| matrix: | ||||||
| os: | ||||||
| - ubuntu-latest | ||||||
| - windows-latest | ||||||
| - macos-latest | ||||||
| python-version: [ 3.12 ] | ||||||
| python-version: [ 3.13 ] | ||||||
| steps: | ||||||
| - uses: actions/checkout@v3 | ||||||
| - uses: actions/checkout@v6 | ||||||
| - name: Install Nix | ||||||
| uses: cachix/install-nix-action@v27 | ||||||
| uses: cachix/install-nix-action@v31 | ||||||
| with: | ||||||
| extra_nix_config: | | ||||||
| experimental-features = nix-command flakes | ||||||
| - name: Setup Cachix | ||||||
| uses: cachix/cachix-action@v15 | ||||||
| uses: cachix/cachix-action@v16 | ||||||
| with: | ||||||
| name: wordweaver | ||||||
| authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' | ||||||
| skipPush: true | ||||||
| - name: Install dependencies | ||||||
| run: | | ||||||
| nix develop --command uv sync --extra dev | ||||||
| - name: Build executable | ||||||
| run: | | ||||||
| nix develop --command uv run python -m PyInstaller Wordweaver.spec | ||||||
| - name: Get version for macOS installer | ||||||
| id: version | ||||||
| run: | | ||||||
| echo "value=$(cat VERSION | tr -d '\n')" >> "$GITHUB_OUTPUT" | ||||||
| if: runner.os == 'macOS' | ||||||
| - name: Build macOS installer | ||||||
| uses: akiojin/generate-mac-installer-github-action@v1.0.4 | ||||||
| with: | ||||||
| output-directory: dist | ||||||
| root-directory: dist | ||||||
| bundle-path: Wordweaver.app | ||||||
| identifier: com.prestonhager.wordweaver | ||||||
| version: ${{ steps.version.outputs.value }} | ||||||
| if: runner.os == 'macOS' | ||||||
| - name: Upload artifacts | ||||||
| uses: actions/upload-artifact@v6 | ||||||
| with: | ||||||
| name: wordweaver-${{ matrix.os }} | ||||||
|
||||||
| name: wordweaver-${{ matrix.os }} | |
| name: wordweaver-${{ runner.os }} |
Copilot
AI
Jan 18, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows build job is installing Python 3.12.0, but this PR upgrades the project to require Python 3.13. This version should be changed to 3.13.0 to be consistent with the project requirements updated in pyproject.toml and uv.lock.
| choco install python --version=3.12.0 | |
| choco install python --version=3.13.0 |
Copilot
AI
Jan 18, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition if: runner.os == 'Windows' is redundant in the build-windows job, which already runs only on windows-latest. The condition will always evaluate to true and can be removed.
| if: runner.os == 'Windows' |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matrix variable
python-versionis defined but never used in the build job steps. Since the job relies on Nix to provide the Python environment, this matrix variable serves no purpose and should be removed to avoid confusion.