Bugfix/add pyinstaller spec#16
Merged
Merged
Conversation
The NSIS installer script expects a single executable at dist/Wordweaver.exe, but the spec was creating a folder-based build. Now Windows builds use onefile mode while macOS/Linux keep the folder-based build for app bundles.
NSIS resolves paths relative to where makensis is invoked, not the NSI file location. Since the workflow runs makensis from the project root, the paths need to be relative to that directory.
Reverts to consistent folder-based output (dist/Wordweaver/) on all platforms. Updates NSIS script to expect dist/Wordweaver/Wordweaver.exe.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes path references in the NSIS installer script to correctly work when invoked from the root directory (as shown in the CI/CD workflow). The paths are updated to align with PyInstaller's output structure and the actual execution context.
Changes:
- Updated
OutFilepath to place the installer in thedistdirectory relative to the root - Updated the main executable path to reference the correct location in
dist\Wordweaver\subdirectory created by PyInstaller's COLLECT
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes small adjustments to the installer script for Wordweaver to update file paths for the output installer and the main executable.
distdirectory instead of its parent.dist\Wordweaversubdirectory.