fix(coding-agent): show progress during /refine - #1035
Conversation
/refine
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f747ebbe1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review All previous findings have been addressed:
Local gates pass:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0401ba71dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review All findings from round 2 addressed:
Local gates pass:
|
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Hi, thanks for taking the time to contribute to Prime Agent! Since open sourcing the project, we’ve received far more pull requests than we can responsibly review and validate. Prime Agent runs directly on users’ machines, so we need to be deliberate about which changes we accept and how they are reviewed. Rather than leave a large backlog that we cannot meaningfully work through, we’re closing the current PR queue and moving to a discussion-first contribution process. We have established new contribution guidelines to help us continue iterating on Prime Agent and better manage contributions from the community. Going forward, we won’t review unsolicited pull requests. Instead, please start with a GitHub Discussion. We’ll identify recurring bugs and feature requests, create Issues for work we want to pursue, and invite pull requests from maintainers or vouched contributors when implementation is ready. Please read the full process documented in our contribution guidelines. While we’re closing this backlog, we’re still reviewing it at a high level to identify recurring bugs, useful ideas, and important problems that we should address ourselves. Thanks again for the time you put into this! |

Summary
Refiningloader while an explicit/refinesession command is active/refinewithout clearing queued prompts or the editor draftCompatibility
This is a TUI-only change that consumes the existing optional
sessionActions.activesnapshot. It adds no daemon command, event, response field, capability, or schema revision; clients attached to older daemons continue to degrade to the existing no-loader behavior.Scope and prior work
This fixes the explicit interactive
/refinepath that can otherwise appear frozen during a long model-backed refinement. It deliberately does not add generic lifecycle state for automatic/background refinement.#447 overlaps with the broader goal, but is currently conflicting and predates the session-action snapshot now on
main. This PR is the minimal current-main alternative for the interactive slash-command path and does not revive #447's queue/core/protocol changes.Validation
npx tsx ../../node_modules/vitest/dist/cli.js --run test/interactive-mode-status.test.ts test/interactive-mode-ctrl-c.test.ts(174 passed)npx tsx ../../node_modules/vitest/dist/cli.js --run test/suite/agent-session-queue.test.ts -t "defers steer heartbeats while a non-streaming session command is running"(1 passed)npm run checkNote
Show elapsed progress and allow cancellation during
/refinein interactive mode/refinesession commands (not just agent streaming), showingRefining · <elapsed> (Ctrl+C to cancel)in the status area.workingLoaderKindfield tracks whether the loader is owned by streaming or/refine, and the loader restarts when ownership changes./refinecommand now callsagentConnection.abort()and restores any queued prompts to the editor.syncWorkingLoader()is called onsession_action_updateevents and during initial snapshot rendering to keep loader state current.Macroscope summarized 6f0b233.