[v0.8 Prompts P01] preserve typed system-prompt provenance - #1177
[v0.8 Prompts P01] preserve typed system-prompt provenance#1177sethkarten wants to merge 23 commits into
Conversation
Add an IPYTHON_CONTROL_PROMPT line instructing the agent to never block the kernel with time.sleep() loops or long sleeps to await slow external work (background runs, sandboxes, sub-agents, remote jobs). A blocked cell holds the turn open, wastes wall-clock, and prevents user interaction. The agent should kick off the work, record its handle/output location, end the turn, and check results on a later turn. Update system-prompt.test.ts exact-match block and add a toContain assertion.
v0.8 stack checkpoint — 2026-08-11 15:50 UTCThis draft PR remains the GitHub Prompts stack surface and will be kept current.
The current remote tip is historical until that verified successor lands; this is not a readiness claim. |
sethkarten
changed the title
|
Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies. |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b54903c. Configure here.
| getThemes(): { themes: Theme[]; diagnostics: ResourceDiagnostic[] }; | ||
| getAgentsFiles(): { agentsFiles: Array<{ path: string; content: string }> }; | ||
| getSystemPrompt(): string | undefined; | ||
| getSystemPromptSource?(): SystemPromptSource; |
There was a problem hiding this comment.
Provenance migration scaffolding remains
Low Severity
P01 keeps transitional dual APIs after the provenance migration: optional getSystemPromptSource?() with a string-fallback helper, plus retained customPrompt beside systemPromptSource. That staging surface duplicates resolution logic and leaves compatibility vocabulary in the completed P01 change.
Additional Locations (2)
Triggered by project rule: Review rules
Reviewed by Cursor Bugbot for commit b54903c. Configure here.
3 participants
Summary
ResourceLoadermethod optional for existing SDK loaders and exportSystemPromptSourcefrom the package root.Cleanup
mainbranch without rewriting published history.Validation
npm run checknpx tsx ../../node_modules/vitest/dist/cli.js --run test/agent-session-runtime-events.test.ts test/suite/agent-session-runtime.test.ts test/system-prompt.test.ts— 55 passednpx tsx ../../node_modules/vitest/dist/cli.js --run test/resource-loader.test.ts -t "distinguishes an absent system prompt"— 1 passedNote
Preserve caller-provided empty system prompt provenance across session rebuilds
SystemPromptSourcediscriminated union (built_in|custom|unknown) in system-prompt.ts to track whether a system prompt came from the built-in default or was explicitly provided by the callerbuildSystemPromptnow usesresolveSystemPromptSourceto reconcile the newsystemPromptSourceoption with the legacycustomPromptfield; an empty-string custom prompt is treated ascustomrather than falling back to the built-in prompt, andunknownprovenance fails closed by returning an empty stringDefaultResourceLoader.extendResourcesdistinguishes absent (undefined) from present-empty ("") system prompt config and exposes the resolved source via the newgetSystemPromptSource()getterAgentSessionpassessystemPromptSourceinto_baseSystemPromptOptionsinstead ofcustomPrompt, preserving empty custom prompts acrossnewSession()rebuildsbuildSystemPromptreturns an empty string forunknownprovenance instead of assembling a default prompt; callers that previously relied on fallback behavior for malformed or missing provenance data will get an empty system promptMacroscope summarized 2584ae8.
Note
Medium Risk
Changes how agent system prompts are chosen, including fail-closed behavior for unknown provenance. Incorrect provenance can alter model instructions across session rebuilds.
Overview
Fixes empty caller-provided system prompts being treated as absent and replaced by the built-in agent prompt on session rebuilds.
Introduces typed
SystemPromptSource(built_in|custom|unknown).buildSystemPromptnow uses that provenance: empty custom content is kept, and unknown provenance returns""instead of assembling the default prompt.DefaultResourceLoaderdistinguishes unset vs explicitly emptysystemPrompt, and sessions prefergetSystemPromptSource()(optional on existing loaders) when rebuilding prompts.Reviewed by Cursor Bugbot for commit 2584ae8. Bugbot is set up for automated code reviews on this repo. Configure here.