feat(client): add dynamo_chat transport + routed_experts to renderer generate#79
Open
biswapanda wants to merge 21 commits into
Open
feat(client): add dynamo_chat transport + routed_experts to renderer generate#79biswapanda wants to merge 21 commits into
biswapanda wants to merge 21 commits into
Conversation
1 task
…ols from dynamo body, raise on missing ids; rename transport to dynamo_chat
1 task
…d, drop routed_experts on dynamo (codex round 2)
…ake); docstring fix
…erge nvext, canonical completion-ids, logprobs alignment)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 30c01b6. Configure here.
…payload to contract
…first-turn stays full)
…trim is now a back-compat fallback
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds a
dynamo_chattransport to the renderer-basedgenerate()client so it can run against NVIDIA Dynamo, which serves no/inference/v1/generateroute. Selected per-call viatransport=; defaults to the existing vLLM path, so behavior is unchanged unless opted in.Two transports:
vllm_generate(default): unchanged —messages → render_ids() → POST /inference/v1/generate → parse_response()(vLLM TITO surface).dynamo_chat:messages → render_ids() → POST /v1/chat/completionswithnvext.token_data(pre-tokenized prompt) +nvext.extra_fields=["engine_data"]. Completion token IDs and logprobs are read back fromnvext.engine_data.Dynamo wire shape (
_post_dynamo_chat)Mirrors the verifiers token client so the payload is identical whether a rollout goes through the token client or the renderer client.
nvext.token_data(Dynamo skips tokenization when present);cache_salt→nvext.cache_salt,priority→nvext.agent_hints.priority; a single placeholder user message; sampling remap (max_tokens→max_completion_tokens,logprobs=N→logprobs=true+top_logprobs=N); passthrough fields ride the Dynamo allowlist. Tools are baked intotoken_databy the renderer (not sent on the wire).routed_experts (MoE expert replay) — now surfaced on dynamo_chat
(Supersedes the earlier "routed_experts intentionally NOT surfaced" note — it now is.)
parsereads routed_experts fromnvext.routed_experts(ornvext.engine_data.routed_experts) and maps it to the downstreamRoutedExpertsPayload{data, shape, start, dtype}. The Dynamo worker returns full-sequence routing withstart=0; the renderer row-trims the leading prompt rows only when the caller explicitly setsrouted_experts_prompt_start— a first-turn request with no caller start stays full-sequence withstart=0(no phantom prefix). Completion logprobs prefernvext.engine_data.completion_logprobs(the same authoritative source as the engine token IDs) over the chat echo; a present-but-empty engine list is authoritative and does not fall back to chat.Other
RendererTransport = Literal["vllm_generate", "dynamo_chat"]alias. A present-but-emptycompletion_token_idsis a valid zero-token completion; only a fully absent field raises. Multimodal renderers raiseNotImplementedErrorondynamo_chat(vLLM path / token-client TITO remain available for VLMs).Type of Change
Review
Codex adversarial review: SIGN-OFF (F1/F2/F3 + the N1 logprob-presence finding resolved; head
5f2a914). All review threads resolved.Testing
tests/test_client.pycovers the Dynamo request body shape (priority/detokenize/sampling remap), routed_experts parse + row-trim (explicitprompt_startvs first-turn full-sequence), engine-logprob preference incl. present-but-empty, and missing/empty completion IDs.Note
Medium Risk
New inference path affects rollout token IDs, logprobs, and MoE expert replay for Dynamo users; default transport is unchanged but parsing/validation errors are now explicit on misconfigured Dynamo responses.
Overview
Adds a
dynamo_chatbackend to renderergenerate(), selected per call viatransport=(defaultvllm_generateleaves existing vLLM/inference/v1/generatebehavior intact).generate()now delegates HTTP to a_Transportstrategy: vLLM posts token IDs to the cached absolute generate URL; Dynamo posts to/chat/completionswithnvext.token_data, merged callernvext, sampling remaps (max_completion_tokens,logprobs/top_logprobs), and denylisted vLLM-only keys routed intonvext(cache_salt,priority,routed_experts_prompt_start). Responses are normalized through_WireResult; Dynamo prefersnvext.engine_datafor completion IDs and logprobs, validatesrouted_expertsto{data, shape, start, dtype}, and can client-trim MoE routing when the worker returns full-sequence data withstart=0. Multimodal ondynamo_chatraisesNotImplementedError.Tests cover Dynamo wire shape,
nvextmerging, missing/misaligned completions and logprobs, routed-experts trimming, and shared POST error propagation for both transports.Reviewed by Cursor Bugbot for commit f5c480d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add
dynamo_chattransport androuted_expertssupport togenerate()transportparameter togenerate()in renderers/client.py (default"vllm_generate"), routing requests to either/inference/v1/generate(vLLM) or/chat/completions(Dynamo); unknown values raiseValueError._DynamoChatTransportwhich builds an OpenAI-style chat body withnvextfields (token IDs, engine data, cache salt, priority,routed_experts_prompt_start), forwards sampling params while dropping vLLM-internal keys, and parsesnvext.engine_datafor completion token IDs and logprobs.routed_expertsprompt rows via_trim_dynamo_routed_expertswhen the worker has not already applied the offset._VllmGenerateTransportwith no behavioral change to that path.NotImplementedErrorfor multimodal inputs andRuntimeErrorwhencompletion_token_idsis absent or logprob length mismatches — these are new hard failures with no fallback.Macroscope summarized f5c480d.