Skip to content

Update DB_URL format in downloader#121

Merged
Priveetee merged 3 commits into
Priveetee:mainfrom
areguig:patch-3
Jun 24, 2026
Merged

Update DB_URL format in downloader#121
Priveetee merged 3 commits into
Priveetee:mainfrom
areguig:patch-3

Conversation

@areguig

@areguig areguig commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The DB_URL environment variable passed to typetype-downloader was using a JDBC connection string (jdbc:postgresql://...), but the downloader is a Go service that expects a standard PostgreSQL DSN (postgres://...). This caused the service to crash on startup.

@Priveetee

Copy link
Copy Markdown
Owner

Thanks for catching this.

The direction looks right: the downloader is a Go service, so it should not receive a JDBC URL.

Before merging, could you also update docker-compose.dev.yml? It still passes:

DB_URL: jdbc:postgresql://postgres:5432/typetype_downloader

so the same startup issue would remain in the dev/beta compose stack.

One small consistency point too: after moving credentials into DB_URL, DB_USER and DB_PASSWORD are still set separately to typetype. If the downloader reads DB_URL first, those become redundant or potentially misleading. I think we should either remove them or align them with the same env vars used in DB_URL.

Expected shape would be something like:

DB_URL: postgres://${DATABASE_USER:-typetype}:${DATABASE_PASSWORD:-typetype}@postgres:5432/typetype_downloader

applied consistently to both production and dev compose files.

@areguig

areguig commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for catching that missing update . And thank you for creating and sharing this tool. It works incredibily well for such a young software . i will be using this daily and will try to do my best to help when needed .

@Priveetee

Copy link
Copy Markdown
Owner

Thanks for the update :)

I added a tiny follow-up commit so we can avoid making you go back and forth again.

It keeps both compose files consistent: the downloader now gets a direct Postgres DSN with sslmode=disable, and I removed the old DB_USER / DB_PASSWORD entries since they are not used when DB_URL is already a postgres:// URL.

Thanks again for spotting the downloader startup issue :p

@Priveetee Priveetee merged commit 0d57eac into Priveetee:main Jun 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants