test : added unit tests for themes.ts#2761
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Owner
|
Closing as duplicate. #2774 was selected as the themes test winner — it uses loops over THEME_OPTIONS making tests maintainable if themes are added, rather than hardcoding every theme ID. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2758.
Summary of What Has Been Done: Added a vitest test file test/themes.test.ts covering all exported pure functions from src/lib/themes.ts.
Changes Made:
Impact it Made: Theme selection is user-facing in settings and on the public profile. These functions are the single source of truth for theme metadata; testing ensures theme IDs are validated correctly and the cycle navigation works without regression.
Hello @Priyanshu-byte-coder, please assign this issue to me (@tmdeveloper007) so I can open a focused PR.