test : added unit tests for rate-limit.ts#2763
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Owner
|
Closing as duplicate. #2733 was selected as the best rate-limit test suite (comprehensive coverage of fallback chain, , window reset, pruning, and bounded-map behavior). Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2760.
Summary of What Has Been Done: Added a vitest test file test/rate-limit.test.ts covering getClientIp and createMemoryFixedWindowRateLimiter from src/lib/rate-limit.ts.
Changes Made:
Impact it Made: The rate limiter protects all API routes from abuse. getClientIp determines which client is rate-limited; incorrect IP detection can cause legitimate users to share limits with abusers or vice versa. Testing the limiter logic ensures the fixed-window algorithm is correctly implemented.
Hello @Priyanshu-byte-coder, please assign this issue to me (@tmdeveloper007) so I can open a focused PR.