test: add unit tests for rate-limit.ts (#2760)#2779
Closed
ANU5565 wants to merge 2 commits into
Closed
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Owner
|
Closing. #2733 was selected as the best rate-limit test suite — it covers all fallback headers and the full logic including pruning. This PR only has a single test for one header. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds essential unit tests for src/lib/rate-limit.ts to ensure robust IP detection and rate-limiting functionality.
Closes #
This closes #2760.
Type of Change
What Changed
Created test/rate-limit.test.ts.
Added test cases for getClientIp including headers (cf-connecting-ip, x-real-ip, x-forwarded-for) and priority handling.
How to Test
Run npm install to ensure dependencies are up to date.
Run npx vitest test/rate-limit.test.ts to execute the new tests.
Verify that all tests pass.
Expected result:
All tests in rate-limit.test.ts should pass with green status
Screenshots / Recordings
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
Additional Context