Add ability to connect to any mysql or redis database#8
Open
rmetcalf9 wants to merge 3 commits intoProcessMaker:masterfrom
Open
Add ability to connect to any mysql or redis database#8rmetcalf9 wants to merge 3 commits intoProcessMaker:masterfrom
rmetcalf9 wants to merge 3 commits intoProcessMaker:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
I was not able to use this image to connect to my own mysql database server
Expected behaviour:
I wanted variables I could set in the env file to specify the mysql host, port, database, username and password.
Actual behaviour:
It is all hard coded in the init script
Solution
How to Test
Build the container and try with different database
Related Tickets & Packages
None
Code Review Checklist