-
Notifications
You must be signed in to change notification settings - Fork 59
Column creation mutation - support for "mirror" and "board_relation" column types + warnings #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lewandowski-commits
wants to merge
12
commits into
ProdPerfect:master
Choose a base branch
from
Lewandowski-commits:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9372111
add missing types
Lewandowski-commits 952b384
add warnings for missing defaults in mirror/board relation columns
Lewandowski-commits 409a011
update default API client version to current
Lewandowski-commits 6881af6
add missing types
Lewandowski-commits 7b89703
add warnings for missing defaults in mirror/board relation columns
Lewandowski-commits 9ed4909
update default API client version to current
Lewandowski-commits 582c9e4
Merge branch 'master' of https://github.com/Lewandowski-commits/monda…
Lewandowski-commits 76e9ee4
Items resource fix typo
olegkron 34ae042
Added mutate_multiple_items_query which allows to perform multiple op…
ab6d344
refactor method
Lewandowski-commits fca26ed
add tests for new features
Lewandowski-commits af168bf
Revert "Items resource fix typo"
Lewandowski-commits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import unittest | ||
| from unittest.mock import patch | ||
| from monday.resources.types import ColumnType | ||
|
|
||
|
|
||
| class TypesTestCase(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
| self.defaults_mirror_missing = {} | ||
| self.defaults_mirror_correct = { | ||
| "relation_column": "some_id", | ||
| "displayed_linked_columns": ["name"] | ||
| } | ||
| self.defaults_board_relation_missing = {} | ||
| self.defaults_board_relation_correct = { | ||
| "boardId": 123 | ||
| } | ||
|
|
||
| @patch('monday.resources.types.warn') | ||
| def test_is_defaults_have_recommended_keys_mirror_missing(self, mock_warn): | ||
| ColumnType.MIRROR.is_defaults_have_recommended_keys( | ||
| self.defaults_mirror_missing) | ||
| mock_warn.assert_called_once() | ||
| self.assertIn("missing recommended keys", mock_warn.call_args[0][0]) | ||
|
|
||
| @patch('monday.resources.types.warn') | ||
| def test_is_defaults_have_recommended_keys_mirror_correct(self, mock_warn): | ||
| ColumnType.MIRROR.is_defaults_have_recommended_keys( | ||
| self.defaults_mirror_correct) | ||
| mock_warn.assert_not_called() | ||
|
|
||
| @patch('monday.resources.types.warn') | ||
| def test_is_defaults_have_recommended_keys_board_relation_missing( | ||
| self, mock_warn): | ||
| ColumnType.BOARD_RELATION.is_defaults_have_recommended_keys( | ||
| self.defaults_board_relation_missing) | ||
| mock_warn.assert_called_once() | ||
| self.assertIn("missing recommended keys", mock_warn.call_args[0][0]) | ||
|
|
||
| @patch('monday.resources.types.warn') | ||
| def test_is_defaults_have_recommended_keys_board_relation_correct( | ||
| self, mock_warn): | ||
| ColumnType.BOARD_RELATION.is_defaults_have_recommended_keys( | ||
| self.defaults_board_relation_correct) | ||
| mock_warn.assert_not_called() | ||
|
|
||
| @patch('monday.resources.types.warn') | ||
| def test_is_defaults_have_recommended_keys_other_type(self, mock_warn): | ||
| ColumnType.TEXT.is_defaults_have_recommended_keys({}) | ||
| mock_warn.assert_not_called() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any breaking changes?