Skip to content

style: optimize home hero layout and trailer transitions #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ProdigyV21 merged 2 commits into from
May 31, 2026
Merged

style: optimize home hero layout and trailer transitions #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3047e53
style: optimize home hero layout spacing, sizing, and alignment for T…
Himanth-reddy May 30, 2026
1dfbfd6
feat: implement graceful cinematic transitions for trailer playback
Himanth-reddy May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/src/main/kotlin/com/arflix/tv/ui/components/TrailerPlayer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ fun TrailerPlayer(
modifier: Modifier = Modifier,
delayMs: Long = 0L,
volume: Float = 0f,
onPlayingChanged: (Boolean) -> Unit = {}
onPlayingChanged: (Boolean) -> Unit = {},
onFirstFrameRendered: () -> Unit = {},
onEnded: () -> Unit = {}
) {
val context = LocalContext.current
var shouldPlay by remember { mutableStateOf(false) }
Expand Down Expand Up @@ -82,7 +84,6 @@ fun TrailerPlayer(
}
if (videoUrl != null) {
shouldPlay = true
onPlayingChanged(true)
} else {
onPlayingChanged(false)
}
Expand All @@ -106,8 +107,13 @@ fun TrailerPlayer(
if (playbackState == Player.STATE_ENDED) {
shouldPlay = false
onPlayingChanged(false)
onEnded()
}
}
override fun onRenderedFirstFrame() {
onPlayingChanged(true)
onFirstFrameRendered()
}
})
}
}
Expand Down
33 changes: 17 additions & 16 deletions app/src/main/kotlin/com/arflix/tv/ui/screens/details/DetailsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.statusBars
import androidx.compose.foundation.layout.statusBarsPadding
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.layout.widthIn
import androidx.compose.foundation.lazy.LazyRow
import androidx.compose.foundation.lazy.itemsIndexed as standardItemsIndexed
import androidx.compose.foundation.rememberScrollState
Expand Down Expand Up @@ -1838,15 +1839,15 @@ private fun DetailsContent(
val ratingValue = parseRatingValue(rating)
val primaryNetworkLogo = item.primaryNetworkLogo?.takeIf { it.isNotBlank() }
val budgetText = budget?.trim()?.takeIf { it.isNotEmpty() && item.mediaType == MediaType.MOVIE }
val overviewMaxHeight = if (isCompactHeight) 68.dp else 72.dp
val overviewMaxHeight = if (isCompactHeight) 96.dp else 104.dp

val separatorStyle = ArflixTypography.caption.copy(
fontSize = 13.sp,
shadow = textShadow
)

Row(
horizontalArrangement = Arrangement.spacedBy(3.dp),
horizontalArrangement = Arrangement.spacedBy(8.dp),
verticalAlignment = Alignment.CenterVertically
) {
Text(
Expand All @@ -1860,7 +1861,7 @@ private fun DetailsContent(
)

if (displayDate.isNotEmpty()) {
Text(text = "|", style = separatorStyle, color = Color.White.copy(alpha = 0.7f))
Text(text = "•", style = separatorStyle, color = Color.White.copy(alpha = 0.5f))
Text(
text = displayDate,
style = ArflixTypography.caption.copy(
Expand All @@ -1873,7 +1874,7 @@ private fun DetailsContent(
}

if (hasDuration) {
Text(text = "|", style = separatorStyle, color = Color.White.copy(alpha = 0.7f))
Text(text = "•", style = separatorStyle, color = Color.White.copy(alpha = 0.5f))
Text(
text = item.duration,
style = ArflixTypography.caption.copy(
Expand All @@ -1886,32 +1887,32 @@ private fun DetailsContent(
}

if (primaryNetworkLogo != null) {
Text(text = "|", style = separatorStyle, color = Color.White.copy(alpha = 0.7f))
Box(modifier = Modifier.height(14.dp).width(1.dp).background(Color.White.copy(alpha = 0.3f)))
AsyncImage(
model = primaryNetworkLogo,
imageLoader = metadataLogoImageLoader,
contentDescription = "Primary streaming provider",
contentScale = ContentScale.Fit,
modifier = Modifier
.height(16.dp)
.width(52.dp)
.height(20.dp)
.widthIn(max = 64.dp)
)
}

if (ratingValue > 0f) {
Text(text = "|", style = separatorStyle, color = Color.White.copy(alpha = 0.7f))
Box(modifier = Modifier.height(14.dp).width(1.dp).background(Color.White.copy(alpha = 0.3f)))
DetailsImdbSvgRatingBadge(
rating = rating,
imageLoader = metadataLogoImageLoader,
ratingFontSize = 13,
logoWidth = 34.dp,
logoHeight = 14.dp,
logoWidth = 48.dp,
logoHeight = 20.dp,
textShadow = textShadow
)
}

if (!budgetText.isNullOrBlank()) {
Text(text = "|", style = separatorStyle, color = Color.White.copy(alpha = 0.7f))
Box(modifier = Modifier.height(14.dp).width(1.dp).background(Color.White.copy(alpha = 0.3f)))
Text(
text = "${stringResource(R.string.budget)} $budgetText",
style = ArflixTypography.caption.copy(
Expand All @@ -1924,24 +1925,24 @@ private fun DetailsContent(
}
}

Spacer(modifier = Modifier.height(6.dp))
Spacer(modifier = Modifier.height(24.dp))

val displayOverview = item.overview

Box(
modifier = Modifier
.width(360.dp)
.widthIn(max = 560.dp)
.height(overviewMaxHeight)
) {
Text(
text = displayOverview,
style = ArflixTypography.body.copy(
fontSize = 12.sp,
fontSize = 16.sp,
fontWeight = FontWeight.Normal,
lineHeight = 16.sp,
lineHeight = 23.sp,
shadow = textShadow
),
color = Color.White.copy(alpha = 0.9f),
color = Color(0xDFFFFFFF),
maxLines = 4,
overflow = TextOverflow.Ellipsis
)
Expand Down
Loading
Loading