Skip to content

Memory Leak in PlaybackCookieJar #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annrose2277-glitch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Memory Leak in PlaybackCookieJar #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions app/src/main/kotlin/com/arflix/tv/ui/screens/player/PlayerScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4996,14 +4996,17 @@ private class PlaybackCookieJar : CookieJar {
val current = cookiesByHost[host]?.toMutableList() ?: mutableListOf()
val now = System.currentTimeMillis()

current.removeAll { it.expiresAt <= now }

cookies.forEach { cookie ->
if (cookie.expiresAt <= now) return@forEach
current.removeAll { existing ->
existing.name == cookie.name &&
existing.domain == cookie.domain &&
existing.path == cookie.path
if (cookie.expiresAt > now) {
current.removeAll { existing ->
existing.name == cookie.name &&
existing.domain == cookie.domain &&
existing.path == cookie.path
}
current.add(cookie)
}
current.add(cookie)
}

if (current.isEmpty()) {
Expand All @@ -5017,15 +5020,17 @@ private class PlaybackCookieJar : CookieJar {
val host = url.host
val now = System.currentTimeMillis()
val list = cookiesByHost[host]?.toMutableList() ?: return emptyList()
val valid = list.filter { cookie -> cookie.expiresAt > now && cookie.matches(url) }
if (valid.size != list.size) {
if (valid.isEmpty()) {

val unexpired = list.filter { it.expiresAt > now }
if (unexpired.size != list.size) {
if (unexpired.isEmpty()) {
cookiesByHost.remove(host)
} else {
cookiesByHost[host] = valid.toMutableList()
cookiesByHost[host] = unexpired.toMutableList()
}
}
return valid

return unexpired.filter { it.matches(url) }
}
}

Expand Down