feat(plugins): Add Sideload Plugin System with External Repo Support#313
Open
test01203 wants to merge 2 commits into
Open
feat(plugins): Add Sideload Plugin System with External Repo Support#313test01203 wants to merge 2 commits into
test01203 wants to merge 2 commits into
Conversation
Author
|
I've manually included the missing .aar file in the latest commit. Please approve the CI run for the new commit. |
Owner
|
Great feature, can really improve ARVIO, but before merge we need it cleaned up and Play behavior made explicit. Required before merge:
After those are fixed, I think this can be a very strong feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Sideload Plugin System with External Repo Support, and addresses all recent developer feedback for a clean merge into the main branch.
Key Changes & Fixes:
ExternalExtensionRunner,PluginManager, UI views) has been correctly staged.quickjs-kt-android-1.0.5-nuvio.aarinapp/libs/.Dagger/MissingBindingandMergeJavaResWorkActionconflicts.build.gradle.ktsto usecompilerOptionsinstead of the deprecatedkotlinOptions.assembleSideloadDebugwith zero errors.findEpisode()logic inExternalExtensionRunner.kt.Ready for review and merge!