-
Notifications
You must be signed in to change notification settings - Fork 17
switch to new steam api #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dapperdodger
wants to merge
1
commit into
Producdevity:staging
Choose a base branch
from
dapperdodger:staging
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+76
−27
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concurrent awaiters of
inflightFetchwill mutate the same Error and double-log.With the new dedup, multiple callers share the same rejected promise, so on failure every caller runs this
catch: each one logs[steamGameSearch] fetchSteamGamesData failed:and each one prepends"Steam games data fetch failed: "to the same Error instance (themessagegetter now already contains the previous prefix). Net effect: duplicate error logs per cold start and a nested message likeSteam games data fetch failed: Steam games data fetch failed: <original>. Mutating a caller-visible Error is also generally risky (loses original stack context for downstream callers likegetSteamAppInfoandgetSteamGamesStats).Prefer wrapping in a fresh Error and logging only once (either in
fetchSteamGamesDataitself, or by checking a flag).🛠️ Proposed fix — wrap instead of mutate
try { const freshData = await inflightFetch steamGamesDataCache.set(cacheKey, freshData) return freshData } catch (error) { const message = error instanceof Error ? error.message : String(error) console.error('[steamGameSearch] fetchSteamGamesData failed:', message) - if (error instanceof Error) { - error.message = `Steam games data fetch failed: ${message}` - } - throw error + throw new Error(`Steam games data fetch failed: ${message}`, { + cause: error instanceof Error ? error : undefined, + }) }📝 Committable suggestion
🤖 Prompt for AI Agents