fix(portmaster): stop modifying existing configs - #17
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The temporary v0.1.0 config migration is no longer needed. Existing
config.txtfiles are now treated as user-owned and left unchanged.What changed
voice_chatandplayer_namesettingsconfig.example.txtbefore setup startsconfig.example.txtremains separate because PortMaster overwrites packaged files during updates. Packaging an activeconfig.txtwould replace user settings during an update or reinstall.Testing
tests/portmaster_launcher_test.shmake checkwith clang-format 21.1.8make test-host-sanitizescripts/build-docker.shunzip -t build/codboz.zipCloses #10
Summary by cubic
Stop modifying existing
config.txt; only create it on first run. Previously the launcher appended missingvoice_chatandplayer_nameto existing configs; now it treatsconfig.txtas user-owned and preserves it byte-for-byte.voice_chatandplayer_name.config.example.txt(or a minimal default if missing).config.example.txtseparate so updates do not overwrite user settings.Rollout
config.txt; shipconfig.example.txtonly.Written for commit eb53c30. Summary will update on new commits.