Skip to content

fix(portmaster): stop modifying existing configs - #17

Merged
Producdevity merged 1 commit into
masterfrom
fix/remove-config-migration
Aug 18, 2026
Merged

fix(portmaster): stop modifying existing configs#17
Producdevity merged 1 commit into
masterfrom
fix/remove-config-migration

Conversation

@Producdevity

@Producdevity Producdevity commented Aug 18, 2026

Copy link
Copy Markdown
Owner

The temporary v0.1.0 config migration is no longer needed. Existing config.txt files are now treated as user-owned and left unchanged.

What changed

  • remove the migration that appended missing voice_chat and player_name settings
  • keep first-run config creation from config.example.txt before setup starts
  • verify existing configs remain byte-for-byte unchanged, including files without a final newline

config.example.txt remains separate because PortMaster overwrites packaged files during updates. Packaging an active config.txt would replace user settings during an update or reinstall.

Testing

  • tests/portmaster_launcher_test.sh
  • make check with clang-format 21.1.8
  • make test-host-sanitize
  • scripts/build-docker.sh
  • unzip -t build/codboz.zip

Closes #10


Summary by cubic

Stop modifying existing config.txt; only create it on first run. Previously the launcher appended missing voice_chat and player_name to existing configs; now it treats config.txt as user-owned and preserves it byte-for-byte.

  • Remove the temporary v0.1.0 migration that appended voice_chat and player_name.
  • Keep first-run creation from config.example.txt (or a minimal default if missing).
  • Keep config.example.txt separate so updates do not overwrite user settings.
  • Update tests to assert exact byte preservation of existing configs (including files without a trailing newline).

Rollout

  • No migration required.
  • Do not package an active config.txt; ship config.example.txt only.

Written for commit eb53c30. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Producdevity, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ff4025e4-4ca0-481e-b3d8-003a29aaa224

📥 Commits

Reviewing files that changed from the base of the PR and between a59d4ea and eb53c30.

📒 Files selected for processing (2)
  • packaging/ports/codboz/CODBOZ.sh
  • tests/portmaster_launcher_test.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Producdevity
Producdevity marked this pull request as ready for review August 18, 2026 17:57
@Producdevity
Producdevity merged commit 41df48c into master Aug 18, 2026
4 checks passed
@Producdevity
Producdevity deleted the fix/remove-config-migration branch August 18, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove temporary config migration logic after v0.1.0

1 participant