Add issue report for apts cleanup crash#34
Draft
google-labs-jules[bot] wants to merge 3880 commits intomainfrom
Draft
Add issue report for apts cleanup crash#34google-labs-jules[bot] wants to merge 3880 commits intomainfrom
google-labs-jules[bot] wants to merge 3880 commits intomainfrom
Conversation
…ents (#15025) Co-authored-by: Shnatu <snatu@google.com>
…execution confirmation for non-interactive mode (#14702) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…on format take priority over ones using the old format (#15116)
Co-authored-by: Abhi <abhipatel@google.com>
… (#14606) Co-authored-by: Miguel Solorio <miguelsolorio@google.com>
Co-authored-by: gemini-cli-robot <gemini-cli-robot@google.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Sehoon Shon <sshon@google.com> Co-authored-by: Adam Weidman <65992621+adamfweidman@users.noreply.github.com> Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com> Co-authored-by: Jenna Inouye <jinouye@google.com>
…e and clean up dead code (#15207)
…und (#15218) Co-authored-by: sgeraldes <sgeraldes@users.noreply.github.com>
- advisors.test.ts: mock scanSystemSync on Windows - thinkingOrchestrator.test.ts: mock scanSystemSync on Windows - imports.test.ts: mock os.homedir for cross-platform home resolution - shell-utils.test.ts: add 15s timeout to PowerShell AST test - shell-permissions.test.ts: add 15s timeout to PowerShell parser test - confirmation-policy.test.ts: add 15s timeout to async tests
Theme A - System Spec (3 failures): - thinkingOrchestrator.test.ts: add loadSystemSpec mock for executeTask() Theme B - PowerShell AST (2 failures): - shell-utils.test.ts: skip live PowerShell tests on CI - shell-permissions.test.ts: skip live PowerShell tests on CI Theme C - Timeouts (6 failures): - vitest.config.ts: reduce Windows threads (2-4 vs 8-16) to prevent worker pool exhaustion causing 'onTaskUpdate' timeouts
- confirmation-policy.test.ts: 15s → 60s timeout - coreToolScheduler.test.ts: 20s → 60s timeout - clipboardUtils.test.ts: skip clipboard tests on Windows CI - gemini.test.tsx: 30s → 90s timeout - scripts/lint.js: Windows-compatible yamllint installation Root cause: Windows process spawning (PowerShell, cmd.exe) is ~10x slower than Linux. Clipboard operations hang in headless CI.
- Fix browser launch blocking on Linux (spawn + unref) - Fix credential import token reuse (reset lastRefresh) - Fix Redirect URI mismatch (decouple binding to 127.0.0.1 from public localhost) - Add standalone browser launch test script
This commit adds a detailed issue report (issue_report.md) analyzing the crash encountered when running the "cleanup downloads" command. The crash is caused by a missing 'TRANSIT' attribute in the 'ObjectTableLabels' class within the 'apts' library, which is part of the sandbox environment.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🤖 Hi @google-labs-jules[bot], I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @google-labs-jules[bot], but I was unable to process your request. Please see the logs for more details. |
|
Size Change: -1 B (0%) Total Size: 23.1 MB ℹ️ View Unchanged
|
This commit updates `issue_report.md` with a detailed architectural proposal to replace the upstream Google sandbox image with a self-managed `terminai/sandbox`. This will allow TerminAI to control internal dependencies (like `apts`) and fix bugs such as the `ObjectTableLabels.TRANSIT` crash.
This commit finalizes the `issue_report.md` with a "brutally exhaustive" architectural specification for the `terminai/sandbox` image. It outlines the strategy to replace the opaque upstream Google sandbox with a self-managed, sovereign build pipeline. This includes a detailed `Dockerfile` blueprint, dependency management strategy, security hardening measures (non-root execution, signing), and migration steps for the internal `apts` library to permanently resolve the `ObjectTableLabels.TRANSIT` crash.
…eer prompt This commit adds a comprehensive architectural plan for migrating TerminAI to a "Sovereign Runtime". This includes: 1. `docs-terminai/specs/principal_engineer_prompt_sovereign_runtime.md`: A hyper-detailed context and prompt document for a Principal Engineer to implement the new architecture. It covers industry research (Claude Computer Use, Open Interpreter), defines a three-tiered execution strategy (Sovereign Sandbox, Managed Host Shim, Embedded Runtime), and details the migration plan for the `apts` library (T-APTS). 2. Updates to `issue_report.md` (implicitly, if any were pending, though this branch focuses on the new spec). The goal is to fix dependency issues (like the `ObjectTableLabels.TRANSIT` crash) by ensuring TerminAI fully owns its execution environment (Docker and Host).
This commit adds `docs-terminai/specs/sovereign_runtime_architecture.md`, which details the architectural strategy to resolve upstream dependency issues (like the `ObjectTableLabels.TRANSIT` crash). The architecture defines a "Three-Tiered Execution Strategy": 1. **Sovereign Sandbox:** A repo-owned Docker image (`packages/sandbox-image`) replacing the opaque upstream Google image. 2. **Managed Host Shim:** A fallback mechanism for non-Docker users that automatically provisions a local virtual environment with the required `terminai-apts` library. 3. **Embedded Runtime:** A future-proof tier for environments without Python. It also includes an impact analysis on existing subsystems (MCP, Extensions, A2A), confirming low risk to these components.
This commit updates `docs-terminai/specs/sovereign_runtime_architecture.md` with a new section (2.4) summarizing research on the recently released "Claude Cowork" feature. Key findings: - Claude Cowork uses a local Virtual Machine (VM) for strong isolation, similar to our Tier 1 (Sovereign Sandbox) strategy. - It validates the industry trend towards heavy isolation for agentic tasks. - It highlights TerminAI's unique differentiator: the Tier 2 (Managed Host Shim) fallback, which supports users who cannot run VMs/Docker (e.g., headless servers, light environments), whereas Claude Cowork requires the full Desktop app infrastructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
issue_report.mddetailing the cause and proposed fixes for theAttributeError: type object 'ObjectTableLabels' has no attribute 'TRANSIT'crash. The analysis identifies the issue as originating from the internalaptslibrary within the sandbox Docker image, not the local repository source.PR created automatically by Jules for task 14822769920264597753 started by @Prof-Harita