Open
Conversation
Phase 1 of chat stop/retry/branch bug fixes: - AbortHandler: filter completed tool calls instead of wiping all (Bug #1) - MessageAlternativeService: stop clearing toolCalls at retry start (Bug #2) - MessageRepository: persist full tool call metadata in branch alternatives (Bug #5) - MessageBranchNavigator: remove dead removeEventListener calls (Bug #6) - New toolCallUtils.ts: shared filterCompletedToolCalls() utility Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Phase 2 of chat stop/retry/branch bug fixes:
- MessageDisplay: replace full re-render with incremental reconciliation
- messageBubbles changed from array to Map<string, MessageBubble>
- setConversation() reconciles incrementally for same conversation,
full render for conversation switches
- New reconcile() method: remove stale, update existing, create new
- Proper cleanup/unload on removed bubbles (Bug #7)
- Preserves live progressive tool accordions during updates (Bug #12)
- MessageBubble: cleanup() now calls unload() with double-call guard
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Phase 3 of chat stop/retry/branch bug fixes: - MessageAlternativeService: full refactor with staging pattern - Stream into cloned conversation (never mutate live object) (Bug #8) - CSS overlay instead of clearing content during retry (Bug #9) - Remove Object.assign reload after branch creation (Bug #3) - Concurrent retry guard via retryInProgress Set - Custom abort handler now uses filterCompletedToolCalls - Removed [Retry] debug console.log statements - styles.css: added .message-retrying overlay with pulse animation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Phase 4 of chat stop/retry/branch bug fixes: - MessageBubble: dynamically create branch navigator when message gains branches during updateWithNewMessage() (Bug #4) - BranchManager: return empty/undefined instead of falling through to original data when active branch has unloaded messages (Bug #10) - ChatView: navigateToBranch() prefers in-memory conversation over stale storage load when branch is current conversation (Bug #11) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
136 tests (95 new + 41 existing), all passing: - toolCallUtils: 14 tests (100% coverage) - AbortHandler: 14 tests (100% coverage) - MessageAlternativeService: 16 tests (91% stmt coverage) - MessageRepository: 9 tests (serialization fidelity) - BranchManager: 26 tests (branch data resolution) - MessageBranchNavigator: 9 tests (lifecycle cleanup) - MessageDisplay: 6 tests (reconciliation basics) New infrastructure: fixtures/chatBugs.ts, mocks/chatService.ts, updated obsidian.ts mock, manual E2E test plan Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
User feedback: overlay approach was wrong. New retry flow: 1. Save original content to branch FIRST (preserves old response) 2. Clear current message, show loading state 3. Stream new response directly (live conversation, not clone) 4. Branch arrows navigate between old and new responses Fixes: - Stop button works during retry (abort controller properly wired) - No text leaking through overlay (overlay removed entirely) - Content clears and restreams fresh as expected - Removed .message-retrying CSS overlay styles - Updated tests to match new flow (142 tests pass) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cancelCurrentGeneration() now calls alternativeService.cancel() to abort the separate AbortController used during retry streaming. Previously, stop only aborted MessageManager's own controller, leaving retry streaming running. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When retrying an AI message that had tool calls with follow-up responses, splice continuation messages out of the conversation and preserve them in the branch. Prevents stale content from appearing below the new streamed response. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MessageBubble.updateWithNewMessage() now destroys progressive tool accordions and removes the tool/image bubble DOM when the updated message has no tool calls. Prevents old tool calls from persisting alongside new ones during retry streaming. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ProfSynapse
added a commit
that referenced
this pull request
Feb 5, 2026
…rage (#16) Fix 12 bugs in chat system's stop, retry, and branch navigation: - Preserve tool calls on stop (AbortHandler filter fix) - Fix serialization of tool call results (MessageRepository) - Fix navigator memory leak (proper Component lifecycle) - Implement incremental message reconciliation (Map-based) - Clear-and-restream retry pattern (save original to branch first) - Wire stop button to cancel retry/alternative streaming - Clean up continuation messages on retry - Clear tool accordions when message cleared during retry - Ensure branch data loading and prevent stale messages - 142 unit tests across 7 new test files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm run testpasses (142 tests)🤖 Generated with Claude Code