Skip to content

Comments

fix: Obsidian plugin store compliance audit#23

Open
ProfSynapse wants to merge 2 commits intomainfrom
fix/plugin-store-audit-fixes
Open

fix: Obsidian plugin store compliance audit#23
ProfSynapse wants to merge 2 commits intomainfrom
fix/plugin-store-audit-fixes

Conversation

@ProfSynapse
Copy link
Owner

Summary

  • CSS variable replacements throughout UI components (~39 files)
  • fetchrequestUrl migration for Obsidian API compatibility
  • addEventListenerregisterDomEvent migration (auto-cleanup on unload)
  • Removed as any casts (0 remaining)
  • Console.log cleanup (398 → 1 remaining in ImageGenerationService.ts:55)
  • XSS fix applied in MessageEditController (innerHTML with dynamic content)
  • Inline style removal (85 → 13 remaining)

Test plan

  • Plugin loads and unloads cleanly in Obsidian
  • MCP server connects via Claude Desktop
  • Chat functionality works end-to-end
  • No console.log spam in production builds

🤖 Generated with Claude Code

ProfSynapse and others added 2 commits February 20, 2026 06:45
- Replace all hardcoded hex/named colors with Obsidian CSS variables in styles.css
- Remove redundant .theme-dark overrides (CSS vars auto-adapt)
- Migrate 10 non-streaming fetch() calls to requestUrl() across LLM adapters
  (Ollama, OpenRouter, OpenRouterImage, Perplexity, Requesty, LMStudio, WebLLM)
- Keep streaming fetch() calls with explanatory comments
- Migrate 15 addEventListener calls to registerDomEvent across 6 UI components
- Remove all 12 remaining `as any` casts with proper type solutions
- Fix XSS vector in MessageEditController: replace innerHTML with DocumentFragment
- Remove ~30 console.log/console.warn statements; convert warn→error where appropriate
- Extract ExecutionErrorService for clean error classification in executePrompts
- Remove dead requestUrl error check in OllamaAdapter (auto-throws on non-2xx)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant