Fix ALA detection for NL and international Shipments#305
Open
OlfatProgressus wants to merge 2 commits into
Open
Fix ALA detection for NL and international Shipments#305OlfatProgressus wants to merge 2 commits into
OlfatProgressus wants to merge 2 commits into
Conversation
Abdalsalaam
reviewed
Apr 8, 2026
Member
Abdalsalaam
left a comment
There was a problem hiding this comment.
LGTM, can you check the comment I added? and also please add a changelog
thanks
|
|
||
| const letterbox = postnlData.letterbox || false; | ||
| const [ isLetterbox, setIsLetterbox ] = useState( | ||
| postnlData.letterbox || false |
Member
There was a problem hiding this comment.
I think adding is_letterbox to the early-exit responses (lines 343-351, 365-373 of Extend_Block_Core.php) is better than this, so the frontend always gets an explicit letterbox signal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes # .
Task url
How to test the changes in this Pull Request:
Other information:
Changelog entry