fix: use consistent Mthreads capitalization in prose#212
Open
mesutoezdil wants to merge 1 commit intoProject-HAMi:masterfrom
Open
fix: use consistent Mthreads capitalization in prose#212mesutoezdil wants to merge 1 commit intoProject-HAMi:masterfrom
mesutoezdil wants to merge 1 commit intoProject-HAMi:masterfrom
Conversation
The Mthreads GPU sharing guide mixed lowercase 'mthreads' and title-case 'Mthreads' when referring to the vendor. The title, the 'Running Mthreads jobs' heading, and other files (faq.md, device-supported.md) already use 'Mthreads', so align the remaining three prose references to match. Resource names, Helm values, URLs, and container images (mthreads.com/vgpu, devices.mthreads.enabled, etc.) are left untouched since those are literal identifiers. Signed-off-by: Mesut Oezdil <versusfinem@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mesutoezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mthreads GPU sharing guide mixed lowercase
mthreadsand title-caseMthreadswhen referring to the vendor in prose. This PR aligns the remaining three lowercase references with the rest of the file (and the wider docs).Other files in the repo already use
Mthreadsconsistently:docs/faq/faq.md→ "Mthreads"docs/userguide/device-supported.md→ "Mthreads"Inside
enable-mthreads-gpu-sharing.mditself, the frontmatter title and the## Running Mthreads jobsheading also useMthreads, so the lowercase prose references were the outliers.Changes
docs/userguide/mthreads-device/enable-mthreads-gpu-sharing.md:mthreads device→Mthreads deviceexclusive mthreads GPU→exclusive Mthreads GPUon mthreads nodes→on Mthreads nodes