fix: drop stray NOTICE1 numbering in iluvatar and mthreads guides#214
Open
mesutoezdil wants to merge 1 commit intoProject-HAMi:masterfrom
Open
fix: drop stray NOTICE1 numbering in iluvatar and mthreads guides#214mesutoezdil wants to merge 1 commit intoProject-HAMi:masterfrom
mesutoezdil wants to merge 1 commit intoProject-HAMi:masterfrom
Conversation
Two notice blocks used 'NOTICE1:' even though there was no matching 'NOTICE2:' — a leftover from an earlier numbered style. Drop the digit so the two callouts match the 'NOTICE:' format used throughout the rest of the device guides (and elsewhere in the same files). Affected: - docs/userguide/iluvatar-device/enable-iluvatar-gpu-sharing.md - docs/userguide/mthreads-device/enable-mthreads-gpu-sharing.md Signed-off-by: Mesut Oezdil <versusfinem@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mesutoezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two device guides had a
> **NOTICE1:**callout even though there was no matchingNOTICE2:— looks like a leftover from an earlier numbered style. Drop the digit so the two callouts match theNOTICE:format used throughout the rest of the same files and the other device guides.Changes
docs/userguide/iluvatar-device/enable-iluvatar-gpu-sharing.mdline 115docs/userguide/mthreads-device/enable-mthreads-gpu-sharing.mdline 67In the mthreads file specifically, line 67 was
NOTICE1:while the very next line (line 68) is alreadyNOTICE:— so they read oddly next to each other.#203 is standardizing
NOTE:/Note:→NOTICE:across the docs but doesn't touch theNOTICE1leftovers. This PR is a small follow-up covering those two lines.