Skip to content

Record the JSPI core's size - #107

Merged
Project516 merged 1 commit into
masterfrom
docs/jspi-core-size
Oct 7, 2026
Merged

Project516 merged 1 commit into
masterfrom
docs/jspi-core-size

Conversation

@Project516

Copy link
Copy Markdown
Owner

update-core-sizes.mjs now reads core-jspi too, and core-sizes.json is regenerated from the published 0.17.0 packages on jsDelivr. The st and mt sizes are unchanged, byte for byte. The JSPI section of usage.md now computes its size comparison from the file instead of hardcoding it, and the known issue that said the size was missing is gone.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fc063f12-670f-42f1-b761-75ca0a5987c8
📥 Commits

Reviewing files that changed from the base of the PR and between 84bfd43 and b625e7d.

📒 Files selected for processing (3)
  • apps/website/docs/getting-started/usage.md
  • apps/website/src/data/core-sizes.json
  • scripts/update-core-sizes.mjs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (12)
  • GitHub Check: build
  • GitHub Check: build-preset (web, st)
  • GitHub Check: build-preset (web, mt)
  • GitHub Check: build-core-jspi
  • GitHub Check: js
  • GitHub Check: build-preset (decode, mt)
  • GitHub Check: build-preset (decode, st)
  • GitHub Check: build-core
  • GitHub Check: build-core-mt
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (c-cpp)
🧰 Additional context used
🪛 markdownlint-cli2 (0.23.2)
apps/website/docs/getting-started/usage.md

[warning] 577-577: Reference links and images should use a label that is defined
Missing link or image reference definition: ""ffmpeg-core.wasm""

(MD052, reference-links-images)


[warning] 578-578: Reference links and images should use a label that is defined
Missing link or image reference definition: ""ffmpeg-core.wasm""

(MD052, reference-links-images)

🔇 Additional comments (5)
scripts/update-core-sizes.mjs (2)

7-7: LGTM!


51-51: 🗄️ Data Integrity & Integration

The artifact publication path is not established by the available repository evidence. The search found no ffmpeg-core-jspi, upload-artifact, or ffmpeg-core-mt workflow references, so the CI artifact name and file layout cannot be confirmed.

apps/website/src/data/core-sizes.json (1)

10-13: LGTM!

apps/website/docs/getting-started/usage.md (2)

577-579: LGTM!


629-629: LGTM!


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated the JSPI core size comparison to use the reported JavaScript and WebAssembly sizes, with the percentage difference calculated from those values.
    • Clarified the known-issues note: the JSPI core is not available in the Playground; its size is no longer described as missing.

Walkthrough

The size updater and website data now include the core-jspi artifact. The usage page uses the size data for its JSPI comparison and no longer says the JSPI core size is absent from core-sizes.json.

Changes

JSPI core size data and documentation

Layer / File(s) Summary
Add core-jspi size data
scripts/update-core-sizes.mjs, apps/website/src/data/core-sizes.json
The updater processes core-jspi through the selected CI-run or jsDelivr path. The size data records ffmpeg-core.js as 97901 and ffmpeg-core.wasm as 32412275.
Update size comparison documentation
apps/website/docs/getting-started/usage.md
The JSPI comparison derives its percentage reduction and displayed sizes from coreSizes. The known-issues list no longer says that the JSPI core size is absent from core-sizes.json.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to b625e

The change adds the JSPI core size to the data and uses it in the documentation. No material merge-blocking risk is established; the manual updater requires a CI run that actually produced the JSPI files.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: recording the JSPI core size.
Description check ✅ Passed The description accurately summarizes the changes to core-jspi size collection, core-sizes.json, and usage.md.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the core size chart,
And finds the JSPI numbers start.
The script adds one more to the row,
The docs show values readers know.
Then off I hop, with ears held high!

Comment @coderabbitai help to get the list of available commands.

@project516-review-bot project516-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates core-sizes.json to include JSPI core sizes, modifies update-core-sizes.mjs to fetch the JSPI core, and changes usage.md to dynamically compute the JSPI size comparison from core-sizes.json instead of hardcoded values, removing the known issue about the missing size.


review-bot, model nvidia/nemotron-3-super-120b-a12b:free, verdict approve

@Project516
Project516 merged commit 82eeb01 into master Oct 7, 2026
33 checks passed
@Project516
Project516 deleted the docs/jspi-core-size branch October 7, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant