Repository navigation
Record the JSPI core's size - #107
Conversation
…size comparison from it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (12)
🧰 Additional context used🪛 markdownlint-cli2 (0.23.2)apps/website/docs/getting-started/usage.md[warning] 577-577: Reference links and images should use a label that is defined (MD052, reference-links-images) [warning] 578-578: Reference links and images should use a label that is defined (MD052, reference-links-images) 🔇 Additional comments (5)
📝 SummarySummary by CodeRabbit
WalkthroughThe size updater and website data now include the ChangesJSPI core size data and documentation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The change adds the JSPI core size to the data and uses it in the documentation. No material merge-blocking risk is established; the manual updater requires a CI run that actually produced the JSPI files. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the core size chart, Comment |
There was a problem hiding this comment.
The PR updates core-sizes.json to include JSPI core sizes, modifies update-core-sizes.mjs to fetch the JSPI core, and changes usage.md to dynamically compute the JSPI size comparison from core-sizes.json instead of hardcoded values, removing the known issue about the missing size.
review-bot, model nvidia/nemotron-3-super-120b-a12b:free, verdict approve
update-core-sizes.mjs now reads core-jspi too, and core-sizes.json is regenerated from the published 0.17.0 packages on jsDelivr. The st and mt sizes are unchanged, byte for byte. The JSPI section of usage.md now computes its size comparison from the file instead of hardcoding it, and the known issue that said the size was missing is gone.