Skip to content
This repository was archived by the owner on Aug 27, 2020. It is now read-only.

Swagger contract for login in user onboarding.#1

Open
Nexengineer wants to merge 2 commits into
masterfrom
A_HIP_1
Open

Swagger contract for login in user onboarding.#1
Nexengineer wants to merge 2 commits into
masterfrom
A_HIP_1

Conversation

@Nexengineer

Copy link
Copy Markdown

No description provided.

Comment thread src/main/resources/static/api.yaml Outdated
- name: account

paths:
/account/login:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/account/login:
/sessions:

should do I guess

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread src/main/resources/static/api.yaml Outdated
Comment on lines +94 to +99
role:
type: string
example: super_admin/admin/lab_assistant
labId:
type: string
example: 100043

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roles are already part of the token, we should leverage. It will be better if we get key cloak to have some field to represent lab id also as part of token. If not, no problem.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

…xpected. Please have a look. If this comes off hold
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants