Merge upstream shibayan/keyvault-acmebot (NET10, ARI, project restructure)#6
Merged
Conversation
Bumps [ACMESharpCore](https://github.com/shibayan/ACMESharpCore) from `aa40536` to `f05287c`. - [Commits](shibayan/ACMESharpCore@aa40536...f05287c) --- updated-dependencies: - dependency-name: ACMESharpCore dependency-version: f05287c7483848fc224a66ec4942becfe6db0fe2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Initial implementation of ACME Renewal Information * Fixed copilot review * Fixed lint error
* Fixed CodeQL autobuild config * Set build mode to autobuild for CodeQL initialization * Update CodeQL build mode to conditionally use autobuild for C# language * Remove debug code
…n permissions (polymind-inc#900) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Migrate to .NET 10 * Use preview version .NET SDK * Update .NET SDK version in Bicep * Autobuild C# in CodeQL * Streamlined csproj properties * Remove unused using * Update nuget packages * Update Function SDKs * Upgrade to .NET 10 GA * Remove preview flag * Update template * Revert deploy template
…-inc#920) Bumps the dependencies group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove ACMESharpCore submodule * Rename to Acmebot * Adjust namespace to Acmebot * Fixed errors custom dns sample * Update bicep for flex consumption
…-inc#934) * Add CodeQL configuration file and update workflow to use it * Refactor CodeQL queries for clarity by separating them into individual lines
* Remove Buypass GO SSL configuration * Rebuild from bicep
Bumps the dependencies group with 2 updates: [actions/setup-dotnet](https://github.com/actions/setup-dotnet) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/setup-dotnet` from 5.0.1 to 5.1.0 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@2016bd2...baa11fb) Updates `github/codeql-action` from 4.31.9 to 4.31.10 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5d4e8d1...cdefb33) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: 5.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: github/codeql-action dependency-version: 4.31.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…olymind-inc#940) Revert "Add CodeQL configuration file and update workflow to use it (polymind-inc#934)" This reverts commit 93ff822.
Removed specific queries from CodeQL initialization.
* Support Certificate profile selection * Update src/Acmebot/Functions/StaticPage.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* feat: add akamai dns provider * fix: copilot review suggestions * fix: formatting * fix: rename to AkamaiEdgeDns
* Support to Flex Consumption deployment * Update generatedToken to use resourceGroup.id for consistency
…d-inc#950) * Update README for clarity and add commercial support section * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comprehensive implementation plan for disaster recovery KeyVault replication feature. Includes architecture, file modifications, data flow, testing checklist, and resolved questions. Co-Authored-By: Jake Farley with Claude Code
Upstream changes incorporated: - Bump to .NET 10 target framework - Rename GetExpiringCertificates -> GetRenewalCertificates - Add ACME Renewal Information (ARI) support - Remove MitigateChainOrder property - Add Akamai Edge DNS provider - Add X509Certificate2Extensions.GetCertificateId() for ARI - Restructure project: KeyVault.Acmebot/ -> src/Acmebot/ - Move deploy templates to deploy/ directory (v5) - Add createUiDefinition.json - CodeQL and workflow permission fixes Custom features preserved: - Certificate Tags feature in SharedActivity.FinalizeOrder - FUNCTIONS_WORKER_RUNTIME = dotnet-isolated - WEBSITE_RUN_FROM_PACKAGE = Azure Gov Cloud blob storage URL - Bicep version pinned to 0.40.2 to match local tooling Co-Authored-By: Jake Farley with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shibayan/keyvault-acmebotinto our forkKeyVault.Acmebot/→src/Acmebot/, deploy templates moved todeploy/MitigateChainOrderpropertyCustom features preserved
SharedActivity.FinalizeOrder)FUNCTIONS_WORKER_RUNTIME = dotnet-isolatedWEBSITE_RUN_FROM_PACKAGEpointing to Azure Gov Cloud blob storage0.40.2to match local toolingTesting
dotnet buildpasses (0 errors, warnings are from upstream code)bicep buildpasses (BCP187 warning ononedeployresource is a type library inaccuracy, not a functional issue)Upstream commits included
07c089b- Workflow permissions fix (Potential fix for code scanning alert no. 5: Workflow does not contain permissions polymind-inc/acmebot#900)50b727b- CodeQL autobuild config fix (Fixed CodeQL autobuild config polymind-inc/acmebot#899)051c36a- CodeQL autobuild mode change (Change CodeQL autobuild mode polymind-inc/acmebot#898)c868472- ACME Renewal Information implementation (Initial implementation of ACME Renewal Information polymind-inc/acmebot#897)8cdceaa- ACMESharpCore submodule bump (Bump ACMESharpCore fromaa40536tof05287cpolymind-inc/acmebot#896)016ccea- Remove MitigateChainOrder property (RemoveMitigateChainOrderproperty polymind-inc/acmebot#895)