Skip to content

[codex] fix spotify redirect setup copy #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Promansis wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[codex] fix spotify redirect setup copy #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/features/agents/components/AgentEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1524,9 +1524,8 @@ export function AgentEditor() {
<p className="text-[0.625rem] text-white/30 leading-relaxed">
Spotify only accepts <code className="text-white/40">https://</code> redirect URIs or loopback (
<code className="text-white/40">http://127.0.0.1</code>). If you&apos;re running Marinara on another
machine over plain HTTP, register the loopback URI anyway and use the paste-back fallback that
appears under the Connect button — or set{" "}
<code className="text-white/40">SPOTIFY_REDIRECT_URI</code> to your HTTPS URL.
machine, register the loopback URI shown above and use the paste-back fallback that appears under
the Connect button.
</p>
</div>
</div>
Expand Down
33 changes: 31 additions & 2 deletions updates/people/promansis.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,40 @@

## Current Work

No current work listed.
- Spotify setup redirect URI instructions
- Status: Ready for review on `fix/spotify-redirect-uri-setup`
- Impact area: Spotify agent setup UI, native Spotify OAuth capability contract
- Next step: Review the focused local commit and manually confirm the Spotify setup copy in the agent editor.
- Blockers: None.

## Owned Bugs

No owned bugs currently listed.
## Spotify setup tells users to set a redirect URI env var that native auth ignores

- Status: Ready for review on `fix/spotify-redirect-uri-setup`
- Owner: Promansis
- Impact area: UI | Rust capability
- Reported: Local backlog item 20
- Last updated: 2026-05-19

### Steps

1. Open the Spotify DJ agent setup.
2. Read the Spotify redirect URI instructions.

### Expected

The setup instructions should describe the redirect URI that native Spotify auth actually uses.

### Actual

The setup copy told users they could set `SPOTIFY_REDIRECT_URI` to an HTTPS URL, but the frontend status and Rust OAuth flow use the fixed loopback callback.

### Notes

- Owner is the Spotify agent setup UI copy, with the Rust Spotify OAuth callback contract reviewed as the dependent capability.
- Fixed by documenting the supported loopback redirect URI and paste-back fallback instead of advertising an unsupported environment override.
- Verification: `pnpm typecheck`; `cargo check --manifest-path src-tauri/Cargo.toml`.

## Status Notes

Expand Down