Skip to content

Testfinally/#39

Open
Promansis wants to merge 22 commits into
local/bunny-coderabbit-reviewerfrom
main
Open

Testfinally/#39
Promansis wants to merge 22 commits into
local/bunny-coderabbit-reviewerfrom
main

Conversation

@Promansis

Copy link
Copy Markdown
Owner

Linked issue

Closes #

Why this change

What changed

Validation

  • pnpm check passes locally
  • Container (Docker / Podman) built and ran without issue
  • Ran the app, clicked through the changes manually
  • Checked edge cases (light + dark mode, mobile viewport, empty states, error paths)
  • Above manual verification completed (describe below)
  • Read and followed CONTRIBUTING.md

Manual verification notes

Docs and release impact

  • No docs changes needed
  • Updated docs (README / CONTRIBUTING / android/README / CHANGELOG) as needed
  • Version/release files updated (only if this PR includes a version bump)

UI evidence (if applicable)

@github-actions github-actions Bot added the ci label Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

✅ Bunny Review Completed

Tip

Review posted. The specimen has left the observation table.

  • Commit: c5f88e4 - Add Bunny auto dispatcher to origin main

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

🐰 Bunny Review

Caution

Specimen unstable. 1 finding(s): 🚫 1 blocking
Repair blocking/high findings and failed controls before merge.

Note

Mode: incremental
Commit: c5f88e4 - Add Bunny auto dispatcher to origin main
Base: 87d217fd

🧭 Specimen Summary

  • The specimen installs an automatic pull_request_target dispatcher, a small ritual meant to awaken the trusted Bunny reviewer for non-draft PRs against refactor. Its privileged surface is admirably narrow — no checkout, no installation, no execution of pull request code. The fascinating failure is more basic: the ritual appears to summon a workflow file that the bounded repository context cannot find.

🔎 Isolated Defects

Severity Location Finding
🚫 BLOCKING .github/workflows/bunny-review-auto.yml:33 Auto dispatch targets a missing reviewer workflow
🤖 Repair prompt for isolated Bunny findings
Use this as an implementation handoff, not as reviewer prose. Keep the response concise, technical, and direct.

Task: verify and repair `.github/workflows/bunny-review-auto.yml` around line 33.
Finding: Auto dispatch targets a missing reviewer workflow
Severity: blocking
Suggested repair: Add the trusted `bunny-review.yml` workflow with the expected `workflow_dispatch` inputs on the target ref, or point this dispatch command at the actual reviewer workflow file that exists.
Validate the fix with the narrowest relevant check.
If the finding is stale, leave the code unchanged and record why.

✅ Control Checks

Status Check Detail
❌ FAIL CI Status One or more expected CI controls failed or were cancelled; the specimen is not fit for merge.
❌ FAIL Workflow dispatch contract The new dispatcher names a reviewer workflow that the bounded repository context cannot locate, an elegant little apparatus for automating exit code 1.

❓ Open Questions

  • None recorded.

🧪 Observations

  • Inspected the incremental diff from 87d217fd2931b735af202cef1a32c5bec3821158 to c5f88e4ef28e1174ce54f182b1f0559d6a68df24; only .github/workflows/bunny-review-auto.yml changed.
  • Read AGENTS.md and the matched .github/ path rules; the focused getting-started skill file was unavailable in the packet.
  • Checked the new pull_request_target workflow for checkout-free execution, token permissions, branch gating, concurrency, and dispatch behavior.
  • Compared the new auto dispatcher against the existing .github/workflows/bunny-review-command.yml dispatch pattern.
  • Considered the skeptical pass request for .github/workflows/bunny-review.yml; the merged evidence preserves the concrete missing-target finding and rejects no additional speculative findings.

🧰 CI Status

  • Frontend, Architecture, and Organization: failure
  • Browser Smoke and Performance: success
  • Rust Capability Layer: success
  • failure: 1 expected CI check group(s) failed; do not merge until CI is repaired.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunny Review inline findings

|| echo "::warning::Unable to write Bunny command status before dispatch."

set +e
DISPATCH_OUTPUT="$(gh workflow run bunny-review.yml \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 BLOCKING: Command dispatch targets a missing reviewer workflow

Location: .github/workflows/bunny-review-command.yml:78

The gateway invokes gh workflow run bunny-review.yml, yet the bounded review context reports no matching .github/workflows/bunny-review.yml contract or workflow-dispatch inputs. Every accepted slash command can therefore mature into a GitHub CLI rejection rather than a review. The wrapper has been assembled, but the organ it stimulates is absent from the observed repository.

Tip

Suggested fix: Add the trusted bunny-review.yml workflow with matching workflow_dispatch inputs, or dispatch an existing workflow file that actually exists on the selected ref.

🤖 Repair prompt for agents
Use this as an implementation handoff, not as reviewer prose. Keep the response concise, technical, and direct.

Task: verify and repair `.github/workflows/bunny-review-command.yml` around line 78.
Finding: Command dispatch targets a missing reviewer workflow
Severity: blocking
Suggested repair: Add the trusted `bunny-review.yml` workflow with matching `workflow_dispatch` inputs, or dispatch an existing workflow file that actually exists on the selected ref.
Validate the fix with the narrowest relevant check.
If the finding is stale, leave the code unchanged and record why.

PR_NUM: ${{ github.event.issue.number }}
COMMENT_BODY: ${{ github.event.comment.body }}
COMMENT_AUTHOR: ${{ github.event.comment.user.login }}
TARGET_REF: refactor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ MEDIUM: Dispatch ref is frozen to an unexplained branch

Location: .github/workflows/bunny-review-command.yml:28

The command hard-codes TARGET_REF: refactor, while the packet names a different review target and repository guidance points normal development at staging. If refactor disappears, lags, or lacks the expected workflow inputs, the accepted command fails or runs stale reviewer logic. A trusted bootstrap should not hide branch selection inside a literal fossil.

Tip

Suggested fix: Derive the dispatch ref from the PR base ref or a documented protected repository variable, and expose that resolved value in the status comment.

🤖 Repair prompt for agents
Use this as an implementation handoff, not as reviewer prose. Keep the response concise, technical, and direct.

Task: verify and repair `.github/workflows/bunny-review-command.yml` around line 28.
Finding: Dispatch ref is frozen to an unexplained branch
Severity: medium
Suggested repair: Derive the dispatch ref from the PR base ref or a documented protected repository variable, and expose that resolved value in the status comment.
Validate the fix with the narrowest relevant check.
If the finding is stale, leave the code unchanged and record why.

dispatch:
if: >
github.event.issue.pull_request &&
startsWith(github.event.comment.body, '/bunny-review') &&

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ LOW: Slash-command matcher admits prefix impostors

Location: .github/workflows/bunny-review-command.yml:17

The job guard uses startsWith(..., '/bunny-review'), so /bunny-reviewer and /bunny-review-anything still dispatch the trusted workflow. The later mode parser is stricter, but the expensive action has already been summoned. The command grammar is therefore looser than the status ritual claims.

Tip

Suggested fix: Use a boundary-aware predicate, such as ^/bunny-review([[:space:]]|$), before dispatching.

🤖 Repair prompt for agents
Use this as an implementation handoff, not as reviewer prose. Keep the response concise, technical, and direct.

Task: verify and repair `.github/workflows/bunny-review-command.yml` around line 17.
Finding: Slash-command matcher admits prefix impostors
Severity: low
Suggested repair: Use a boundary-aware predicate, such as `^/bunny-review([[:space:]]|$)`, before dispatching.
Validate the fix with the narrowest relevant check.
If the finding is stale, leave the code unchanged and record why.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunny Review inline findings

# This pull_request_target workflow is intentionally a dispatcher only.
# It must not checkout, install, or execute code from the pull request.
gh workflow run bunny-review.yml \
--repo "${{ github.repository }}" \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 BLOCKING: Auto dispatch targets a missing reviewer workflow

Location: .github/workflows/bunny-review-auto.yml:33

The dispatcher invokes gh workflow run bunny-review.yml, yet the provided workflow context does not contain that workflow, and the adjacent Bunny command workflow uses the same apparently absent target. GitHub rejects dispatches to nonexistent workflow files, so eligible PR events would produce failed automation rather than reviews. A machine built to observe the experiment cannot begin if its heart is imaginary.

Tip

Suggested fix: Add the trusted bunny-review.yml workflow with the expected workflow_dispatch inputs on the target ref, or point this dispatch command at the actual reviewer workflow file that exists.

🤖 Repair prompt for agents
Use this as an implementation handoff, not as reviewer prose. Keep the response concise, technical, and direct.

Task: verify and repair `.github/workflows/bunny-review-auto.yml` around line 33.
Finding: Auto dispatch targets a missing reviewer workflow
Severity: blocking
Suggested repair: Add the trusted `bunny-review.yml` workflow with the expected `workflow_dispatch` inputs on the target ref, or point this dispatch command at the actual reviewer workflow file that exists.
Validate the fix with the narrowest relevant check.
If the finding is stale, leave the code unchanged and record why.

@github-actions github-actions Bot added the docs label Jun 6, 2026
Promansis and others added 4 commits June 6, 2026 13:15
* Fix mobile composer text input collapse (Pasta-Devs#1136)

* Fix tracker aliases, avatars, HUD temps, and changelog (Pasta-Devs#1137)

Resolve tracker characters through active-chat names, aliases, title/comment aliases, and bracketed aliases so group chats can match card names that differ from tracker names.

Preserve uploaded NPC tracker avatars and portrait focus across agent refreshes, including first snapshot writes, without copying manual avatars onto real character-card IDs.

Reuse the shared temperature display helpers in the roleplay HUD so the tracker temperature unit setting applies there too.

Backfill changelog entries for recent Xel PRs and record the tracker hotfix under 1.6.1.

* Reduce chat startup and focus refetch lag

* Revert "Reduce chat startup and focus refetch lag"

This reverts commit e85da38.

* Register pre-alpha workflow on default branch

* Add Bunny review command bootstrap (Pasta-Devs#1821)

* Register Bunny auto review dispatcher on main (Pasta-Devs#1872)

* Enable Bunny dispatch for draft PRs (Pasta-Devs#2026)

* Update Bunny auto dispatch bootstrap (Pasta-Devs#2261)

* Enable Bunny review bootstrap on main (Pasta-Devs#2406)

* Fix Bunny main CI check names

---------

Co-authored-by: Xel <Xelvanas@gmail.com>
Co-authored-by: Spicy_Marinara <mgrabower97@gmail.com>
Co-authored-by: munimunigamer <munimunigamer@protonmail.com>
Co-authored-by: Promansis <damon.kyle.walling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants