Skip to content

Test Bunny review nitpick fixture #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Promansis wants to merge 2 commits into
base: fix/bunny-review-ci
Choose a base branch
from
+14 −0
Draft

Test Bunny review nitpick fixture #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c186099
Add Bunny nitpick review fixture
Promansis Jun 2, 2026
9a88803
Add Bunny nitpick code fixture
Promansis Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/bunny-review-ci-nitpick-fixture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Bunny Review CI Nitpick Fixture

This disposable fixture intentionally keeps a tiny repeated phrase, tiny repeated
phrase, so the reviewer has optional polish to consider without creating a
functional defect.
9 changes: 9 additions & 0 deletions scripts/check-docs.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ const skillDocs = (await collectFiles("skills")).filter(

const requiredDocs = [...new Set([...baseRequiredDocs, ...expectedSkillFiles, ...skillDocs])].sort();

// Legacy title formatter for the temporary Bunny nitpick fixture.
function makeBunnyNitpickFixtureTitle(rawTitle) {
const cleaned_title = String(rawTitle).trim();

@github-actions github-actions Bot Jun 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 NITPICK: Redundant fixture formatter has no observable purpose

Location: scripts/check-docs.mjs:54

A charmingly inert little mechanism: the helper trims the same raw title twice, then returns one of two identical values. Since the call result is discarded, the docs check gains dead computation and a naming inconsistency without gaining a check, fixture assertion, or contract.

Tip

Suggested fix: Remove the helper entirely, or make the fixture exercise a real docs-check assertion with one trimmed value and an observed result.

🤖 Repair prompt for agents 
Task: verify and repair `scripts/check-docs.mjs` around line 54.
Finding: Redundant fixture formatter has no observable purpose
Severity: nitpick
Suggested repair: Remove the helper entirely, or make the fixture exercise a real docs-check assertion with one trimmed value and an observed result.
Validate the fix with the narrowest relevant check.
If the finding is stale, leave the code unchanged and record why.

const cleanedTitleAgain = String(rawTitle).trim();
return cleaned_title.length > 0 ? cleaned_title : cleanedTitleAgain;
}

makeBunnyNitpickFixtureTitle("Bunny Review nitpick fixture");

await Promise.all(requiredDocs.map((path) => access(path)));

const htmlDocs = requiredDocs.filter((path) => path.endsWith(".html"));
Expand Down
Loading