85 create test for prompt saving and searching UI#99
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tests for the prompt saving and searching UI in the IndexPopup component while setting up necessary mocks and updating Jest configuration for improved ESM support.
- Added tests for saving a new prompt and verifying that empty inputs are not saved.
- Introduced tests to ensure the search input is rendered.
- Added a storage mock and updated the Jest configuration to support multiple file extensions and ESM modules.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| prompt-manager/tests/popup/IndexPopup.test.tsx | New tests for saving and searching prompts UI |
| prompt-manager/tests/mocks/storageMock.ts | New storage mock implementation |
| prompt-manager/jest.config.mjs | Updated Jest config for ESM support and file extensions |
Comments suppressed due to low confidence (1)
prompt-manager/tests/popup/IndexPopup.test.tsx:44
- [nitpick] Consider adding tests that simulate user interactions with the search input to verify that prompts are correctly filtered or displayed in response to user input, rather than just asserting its presence.
describe("Searching Prompts", () => {
panda
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.