feat:webhook-subscription-ui - #462
Merged
Wilfred007 merged 2 commits intoAug 20, 2026
Merged
Conversation
Contributor
|
@LamsOfJos thank you for the work done so far, kindly check failing checks |
no-misused-promises flagged the async handleCreate passed directly to form onSubmit, and exhaustive-deps flagged loadSubscriptions being called from useEffect without being a listed dependency. Wrap the submit handler and move the loader inside the effect, matching the pattern already used elsewhere in the app (TransactionHistory, Forecasting). Verified npm run lint, prettier --check, and npm run build all pass locally.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webhookApi.tsservice wired to the existing/webhooks/subscribe,/webhooks/subscriptionsendpoints.WebhookSettings.tsxpage: create form (target URL, signing secret, event-type selection), subscription list with delete/revoke action, and loading/empty/error states matching existing UI patterns.Settings.tsxand routed at/settings/webhooks.enandestranslation files — no hardcoded strings, consistent with Complete i18n coverage: replace hardcoded UI strings with translation keys #416.Test plan
npm run build/tsc --noEmitinfrontend/GET /webhooks/subscriptions(or DB, once persistence lands)Closes #449