fix: file exists on consecutive metric evaluations#699
Merged
Conversation
This change resolves a FileExistsError caused by shutil.copytree when the destination directory already exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change resolves a FileExistsError caused by shutil.copytree when the destination directory already exists.
TL;DR The Cause
Setting
When the model under evaluation is a complex one (i.e., have submodules) such as Qwen-Image-2512, the metrics for each submodule are saved in a nested directory. When the evaluation comprise multiple
GPUMemoryStatsmetrics, thesave_pretrainedmethod is invoked for each metric. When the model is smashed, the particular save function isSAVE_FUNCTIONS.save_before_apply.Problem
The
save_before_applyfunction distinguishes between files and directories and invokesshutil.copyandshutil.copytreecorrespondingly. However, they work differently with their default parameters. Whilecopyalways writes the file unconditionally (i.e., if there is already one with such a name, it is replaced),copytreefails when the directory exists.copy documentation; relevant
copytree documentation; relevant
Related Issue
Fixes #(issue number)
Type of Change
Testing
uv run pytest -m "cpu and not slow")For full setup and testing instructions, see the Contributing Guide.
Checklist
Thanks for contributing to Pruna! We're excited to review your work.
New to contributing? Check out our Contributing Guide for everything you need to get started.