Add practical walkthroughs and stronger validation#6
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8f9c0c584
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,101 @@ | |||
| # Getting Started | |||
There was a problem hiding this comment.
Record major documentation additions in the log
This commit adds a new getting-started guide plus walkthroughs, playbooks, checklists, and filled examples, but knowledge/log.md is not updated. The repo instructions in AGENTS.md explicitly require updating knowledge/log.md when adding major documentation, so this docs batch will be missing from the project change log that future readers and agents rely on.
Useful? React with 👍 / 👎.
| } else { | ||
| console.log(`${name} correctly failed against unsafe fixtures.`); |
There was a problem hiding this comment.
Assert the specific unsafe fixture failures
Because the new fixture test treats any non-zero exit as success for the whole unsafe directory, one detector regression can be masked by a different fixture still failing; for example, redaction URL detection could stop working while the UUID fixture keeps redaction-check non-zero. That means npm test can report that unsafe fixtures are covered without proving each intended unsafe pattern is still detected, so the helper should scan fixtures individually or verify expected findings in the output.
Useful? React with 👍 / 👎.
Summary
Validation