test(auth): address review comments on JwtValidator unit tests#12
Merged
Psyborgs-git merged 3 commits intoadd-jwt-validator-tests-12249440911468361910from Feb 26, 2026
Merged
Conversation
Co-authored-by: Psyborgs-git <49641518+Psyborgs-git@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit tests for JwtValidator in auth package
test(auth): address review comments on JwtValidator unit tests
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up
packages/auth/src/jwt.test.tsbased on PR review feedback.Changes
type Mockfrom the vitest import line/** Tests for @orch/auth/jwt — JwtValidator unit tests */per project conventionvalidate()calls: Refactor "missing issuer" and "provider not found" tests to callvalidate()once, capture the error, and assert all properties on it — instead of calling it 2–3 times with separateexpect(...).rejectschainsrethrow OrchestratorErrortest body to 4-space indent, consistent with the rest of the fileBefore (redundant calls):
After (single call):
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.