Skip to content

fix(core): ignore option flags in FROM and COPY instruction parsing#6

Merged
PunGrumpy merged 4 commits into
mainfrom
advisor/002-fix-from-copy-option-parsing
Jul 11, 2026
Merged

fix(core): ignore option flags in FROM and COPY instruction parsing#6
PunGrumpy merged 4 commits into
mainfrom
advisor/002-fix-from-copy-option-parsing

Conversation

@PunGrumpy

Copy link
Copy Markdown
Owner

This PR resolves Plan 002: Ignore option flags in FROM and COPY instruction parsing.

Summary

  1. Option Filtering: Updated linter rules (pin-image-version, prefer-slim-base, and order-layers) to ignore any arguments starting with -- (e.g., --platform=linux/amd64 or --chown=node:node) before resolving base image names or copy sources.
  2. Implementation Polish: Refactored the code to use the idiomatic .find() array method instead of .filter() + destructuring, satisfying formatting and linting rules cleanly without adding any eslint-disable comments.
  3. Type Safety & Guards: Added safety checks to correctly skip/continue in case no matching arguments are resolved.
  4. Changeset: Included a changeset file to ensure the published @docker-doctor/cli package version is properly bumped upon merge.

All tests, typechecks, builds, and style rules pass cleanly.

@vercel

vercel Bot commented Jul 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docker-doctor Ready Ready Preview, Comment Jul 11, 2026 5:49pm

@PunGrumpy PunGrumpy merged commit 60b743d into main Jul 11, 2026
9 checks passed
@PunGrumpy PunGrumpy deleted the advisor/002-fix-from-copy-option-parsing branch July 11, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant