fix(howtogalaxy): should_simulate every dataset load; run under SMALL_DATASETS#30
Merged
Merged
Conversation
…_DATASETS Slice 2/3 of the HowTo should_simulate migration (mirror of HowToLens#39). Makes every HowToGalaxy tutorial run under PYAUTO_SMALL_DATASETS=1 (16x16) for fast CI. - Migrate all 17 raw `if not dataset_path.exists():` guards to `ag.util.dataset.should_simulate(str(dataset_path))` (autogalaxy namespace). - tutorial_3_fitting: fix the 1st-load guard to run the correct producer (`tutorial_2_data.py` makes the `howtogalaxy` dataset; it wrongly ran `simulators/simple.py`) and add a guard for the 2nd load (`simple`). - Remove the dead `howtogalaxy/` + `guides/` PYAUTO_SMALL_DATASETS-unset overrides (matched zero files). - Regenerate notebooks + navigator catalogue. Verified: every chapter passes on a FRESH dataset/ (cloud shard isolation) under SMALL_DATASETS=1 — ch1 6/6, ch2 8/8, ch3 3/3, ch4 5/5. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29. Slice 2/3 of the HowTo should_simulate migration (mirror of merged HowToLens#39).
Scripts Changed
if not dataset_path.exists():→ag.util.dataset.should_simulate(str(dataset_path))(autogalaxy namespace) across chapters 1–4 + optional.chapter_1_introduction/tutorial_3_fitting.py— fix 1st-load guard to run the correct producer (tutorial_2_data.pymakeshowtogalaxy; was wronglysimulators/simple.py), and add a guard for the 2nd load (simple).config/build/env_vars.yaml— remove the deadhowtogalaxy/+guides/SMALL_DATASETS-unset overrides.workspace_index.json.Verification
Every chapter passes on a fresh
dataset/(cloud-shard isolation) underPYAUTO_SMALL_DATASETS=1: ch1 6/6, ch2 8/8, ch3 3/3, ch4 5/5.Heart RED at ship; opened under the corrective-PR exception scoped to
workspace validation not passing (10 failed, 2026-07-20T15-09-29Z). Merge deferred to human. Slice 3/3 (HowToFit) follows.