fix: un-park pixelization scripts (stale NEEDS_FIX, now green)#31
Merged
Conversation
The imaging/data_preparation/manual/mask_irregular script now runs green on clean main (PASSED 8.6s via the build's own execute_script runner). The 2026-04-10 'silent failure' was Convolver.from_gaussian API drift, since fixed by the PyAutoArray convolver consolidation (#360/#361). Folded into this task per the mask_irregular_silent_failure prompt (all 4 imaging repos, one root cause). autogalaxy_workspace + HowToGalaxy handled here; autolens_workspace + HowToLens ride slam-adapt-inversion-cascade (#300). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The LinAlgError 'matrix not positive definite' markers for the chapter_4 tutorial_5 fit and the pixelization modeling scripts were fixed by the PyAutoArray GaussianKernel PD-guarantee (f1817af0) and never removed. Verified green end-to-end in build-sweep mode (PYAUTO_TEST_MODE=2, real data). Removes 3 stale NEEDS_FIX markers; unrelated markers left intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
Folded in (concurrent session): a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 3 stale
NEEDS_FIXmarkers fromconfig/build/no_run.yaml. TheLinAlgError: matrix not positive definitefailures for the chapter-4tutorial_5_model_fitand the pixelization modeling scripts were fixed by thePyAutoArray GaussianKernel PD-guarantee (
f1817af0) and never removed. Nosource or script changes are needed -- marker cleanup with proof the scripts
are green.
Verification:
tutorial_5_model_fitruns GREEN end-to-end in thebuild-sweep mode that births the markers (
PYAUTO_TEST_MODE=2, real data). Theshared
GaussianKernelinversion path was independently proven robust acrossthe entire LogUniform prior via a 40-draw numpy A/B (0 raises, 0 non-finite) in
the paired autogalaxy_workspace PR.
Addresses Heart RED reason
"58 stale parked script(s)"(corrective PR).Scripts Changed
No script edits --
config/build/no_run.yamlonly. Markers removed:howtogalaxy/chapter_4_pixelizations/tutorial_5_model_fit-- wasLinAlgError: matrix not positive definite(verified green here)imaging/features/pixelization/modeling-- shared skip entry; underlying autogalaxy_workspace script verified greeninterferometer/features/pixelization/modeling-- shared skip entry; underlying autogalaxy_workspace script verified greenUnrelated
NEEDS_FIXmarkers (ellipse KeyError, over_sampling plotter drift, imaging/modeling KeyError) left intact.Test Plan
tutorial_5_model_fitverified green end-to-end (PYAUTO_TEST_MODE=2, real data)Refs #140 (paired with autogalaxy_workspace#141).
Generated by the PyAutoLabs agent workflow.