chore(no_run): drop inert copy-pasted imaging/modeling entry#32
Merged
Conversation
The `autogalaxy_workspace/scripts/imaging/modeling` NEEDS_FIX entry was copy-pasted from autogalaxy_workspace's no_run.yaml and matches zero files in this repo: HowToGalaxy contains only `chapter_*/` and `simulators/`, and patterns containing `/` are substring-matched against the file path. The failure it cited was real but library-side and is now fixed upstream; autogalaxy_workspace removed its own (live) marker in PyAutoLabs/autogalaxy_workspace#142. Refs PyAutoLabs/autogalaxy_workspace#143 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an inert entry from
config/build/no_run.yaml:Why this entry is dead, not a parked script
The pattern is the literal path
autogalaxy_workspace/scripts/imaging/modeling— copy-pasted from autogalaxy_workspace's ownno_run.yaml. HowToGalaxy contains onlyscripts/chapter_*/andscripts/simulators/, and patterns containing/are substring-matched against the file path, so this entry matches zero files.find HowToGalaxy -path '*imaging/modeling*'returns nothing.It was never a second instance of the failure — just cruft. The same copy-paste left other dead entries in this list (
guides/,gui/,ellipse/,fits_make), which this PR deliberately leaves alone to keep the change reviewable.The underlying bug was real, library-side, and is already fixed
Investigated as part of PyAutoLabs/autogalaxy_workspace#143:
mainunder both the smoke profile (PYAUTO_TEST_MODE=2) and the release-fidelity profile (PYAUTO_TEST_MODE=1, real sampler/output/visualization/checks, JAX on) — exit 0, zeroKeyError.48dad395.KeyError. The regression was model-composition/kwargs drift in PyAutoGalaxy/PyAutoFit, fixed upstream between April and July.autogalaxy_workspace removed its own (live) marker in PyAutoLabs/autogalaxy_workspace#142, merged 2026-07-21.
Scripts Changed
None (config-only edit to
config/build/no_run.yaml). No script in this repo changes behaviour, and no script returns to validation — the removed entry was gating nothing. Notebooks are therefore not regenerated.Refs PyAutoLabs/autogalaxy_workspace#143
🤖 Generated with Claude Code