chore(no_run): drop 2 dead NEEDS_FIX markers#35
Merged
Conversation
Both entries were copy-pasted from autogalaxy_workspace's no_run.yaml when the tutorials were split into this repo, and match zero files here: HowToGalaxy contains only scripts/chapter_*/ and scripts/simulators/, and patterns containing '/' are substring-matched against the file path. They advertise open bugs that do not exist and inflate Heart's stale-parked script count. Live entries are unchanged (tutorial_searches still resolves). Refs #34 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes two
no_run.yamlentries that match zero files in this repo:Both were copy-pasted from autogalaxy_workspace's list when the tutorials were split into this repo. HowToGalaxy contains only
scripts/chapter_*/andscripts/simulators/, and patterns containing/are substring-matched against the file path (PyAutoHands/autobuild/build_util.py::should_skip), so neither has ever gated anything here.They are not harmless: they advertise open bugs that do not exist and inflate Heart's stale-parked-script count (currently 58).
Audit context: 17 of this repo's 18 entries match zero files. Only the dead
NEEDS_FIXones are removed here; the remaining cruft is reported in #34 and left alone, since several are stem patterns that may be prospective guards.Verification: YAML re-parses (16 entries), and the live-entry set is byte-identical before and after —
tutorial_searchesstill resolves. NoNEEDS_FIXstring remains in the file.Scripts Changed
None (config-only). No script returns to or leaves validation — the removed entries were gating nothing. Notebooks not regenerated.
Refs #34
🤖 Generated with Claude Code